Pip: Improve error messages for option values #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way any renaming of option names is automatically reflected in the messages. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportBase: 57.87% // Head: 57.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5956 +/- ##
=========================================
Coverage 57.87% 57.88%
Complexity 2044 2044
=========================================
Files 322 322
Lines 18699 18697 -2
Branches 3816 3816
=========================================
Hits 10822 10822
+ Misses 6824 6822 -2
Partials 1053 1053
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This ensures that the default values are always accepted values. Signed-off-by: Sebastian Schuberth <[email protected]>
This is not needed anymore as of c885541. Signed-off-by: Sebastian Schuberth <[email protected]>
fviernau
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.