Fixed regression test failure #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecaat
reviewed
Nov 21, 2023
sql/backup_from_standby.sh
Outdated
| # mkdir -p ${TBLSPC_PATH}/pgbench | ||
| # psql --no-psqlrc -p ${TEST_PGPORT} -d postgres > /dev/null 2>&1 << EOF | ||
| # CREATE TABLESPACE pgbench LOCATION '${TBLSPC_PATH}/pgbench'; | ||
| # CREATE DATABASE pgbench TABLESPACE = pgbench; |
There was a problem hiding this comment.
Do we need to comment out the line?
There was a problem hiding this comment.
Sorry, I think it's better to replace to CREATE DATABASE pgbench;
There was a problem hiding this comment.
We don need the line. So I removed this line and CREATE DATABASE pgbench to replaced it
sql/backup_from_standby.sh
Outdated
|
|
||
| pgbench -i -s $SCALE -p ${TEST_PGPORT} -d pgbench > ${TEST_BASE}/pgbench.log 2>&1 | ||
| pgbench -i -s $SCALE -p ${TEST_PGPORT} -d postgres > ${TEST_BASE}/pgbench.log 2>&1 |
There was a problem hiding this comment.
I think it's better to separate another commit if you want to change the database.
(But, I think the change not seems to be necessary.)
There was a problem hiding this comment.
Yes I agree with you. So I revert this change.
sql/backup_from_standby.sh
Outdated
| CREATE TABLESPACE pgbench LOCATION '${TBLSPC_PATH}/pgbench'; | ||
| CREATE DATABASE pgbench TABLESPACE = pgbench; | ||
| EOF | ||
| # mkdir -p ${TBLSPC_PATH}/pgbench |
There was a problem hiding this comment.
I think we need the reason why it's commented out.
Change the backup_from_standby test item because it is not possible to create a streaming replication with external tablespaces on one localhost. So I removed command about created external tablespace. And I used pg_basebackp command to replaced pg_backup_start() and pg_backup_stop().
zwyan0
force-pushed
the
fix_test_failure
branch
from
23b3b13
to
00d0198
Compare
mikecaat
approved these changes
Nov 21, 2023
|
I confirmed the change. Thanks for your works! |
zwyan0
added a commit
that referenced
this pull request
Nov 22, 2023
* Change the backup_from_standby test item. Change the backup_from_standby test item because it is not possible to create a streaming replication with external tablespaces on one localhost. So I removed command about created external tablespace. And I used pg_basebackp command to replaced pg_backup_start() and pg_backup_stop(). * Corrected parameter values.
zwyan0
added a commit
that referenced
this pull request
Nov 22, 2023
* Change the backup_from_standby test item. Change the backup_from_standby test item because it is not possible to create a streaming replication with external tablespaces on one localhost. So I removed command about created external tablespace. And I used pg_basebackp command to replaced pg_backup_start() and pg_backup_stop(). * Corrected parameter values.
zwyan0
added a commit
that referenced
this pull request
Nov 22, 2023
* Change the backup_from_standby test item. Change the backup_from_standby test item because it is not possible to create a streaming replication with external tablespaces on one localhost. So I removed command about created external tablespace. And I used pg_basebackp command to replaced pg_backup_start() and pg_backup_stop(). * Corrected parameter values.
zwyan0
added a commit
that referenced
this pull request
Nov 22, 2023
* Change the backup_from_standby test item. Change the backup_from_standby test item because it is not possible to create a streaming replication with external tablespaces on one localhost. So I removed command about created external tablespace. And I used pg_basebackp command to replaced pg_backup_start() and pg_backup_stop(). * Corrected parameter values.
zwyan0
added a commit
that referenced
this pull request
Nov 22, 2023
* Change the backup_from_standby test item. Change the backup_from_standby test item because it is not possible to create a streaming replication with external tablespaces on one localhost. So I removed command about created external tablespace. And I used pg_basebackp command to replaced pg_backup_start() and pg_backup_stop(). * Corrected parameter values.
zwyan0
added a commit
to zwyan0/pg_rman
that referenced
this pull request
Nov 22, 2023
* Change the backup_from_standby test item. Change the backup_from_standby test item because it is not possible to create a streaming replication with external tablespaces on one localhost. So I removed command about created external tablespace. And I used pg_basebackp command to replaced pg_backup_start() and pg_backup_stop(). * Corrected parameter values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem that caused some regression tests of pg_rman to fail since 15.4.