Add counting of shell parsing errors

checks/shell_download_validate.go

@@ -17,6 +17,7 @@ package checks
 import (
 	"bufio"
 	"bytes"
+	"context"
 	"errors"
 	"fmt"
 	"net/url"
@@ -25,10 +26,12 @@ import (
 	"regexp"
 	"strings"
 
+	opencensusstats "go.opencensus.io/stats"
 	"mvdan.cc/sh/v3/syntax"
 
 	"github.com/ossf/scorecard/v2/checker"
 	sce "github.com/ossf/scorecard/v2/errors"
+	"github.com/ossf/scorecard/v2/stats"
 )
 
 var (
@@ -679,6 +682,8 @@ func validateShellFileAndRecord(pathfn string, content []byte, files map[string]
 	in := strings.NewReader(string(content))
 	f, err := syntax.NewParser().Parse(in, "")
 	if err != nil {
+		ctx := context.Background()
+		opencensusstats.Record(ctx, stats.ShellParseErrors.M(1))
 		// Note: this is caught by internal caller and only printed
 		// to avoid failing on shell scripts that our parser does not understand.
 		// Example: https://github.com/openssl/openssl/blob/master/util/shlib_wrap.sh.in

cron/worker/main.go

@@ -146,6 +146,7 @@ func startMetricsExporter() (monitoring.Exporter, error) {
 		&stats.CheckErrorCount,
 		&stats.RepoRuntime,
 		&stats.OutgoingHTTPRequests,
+		&stats.ShellParseErrorCount,
 		&githubstats.GithubTokens); err != nil {
 		return nil, fmt.Errorf("error during view.Register: %w", err)
 	}

stats/measures.go

@@ -27,4 +27,10 @@ var (
 		stats.UnitSeconds)
 	// HTTPRequests measures the count of HTTP requests.
 	HTTPRequests = stats.Int64("HTTPRequests", "Measures the count of HTTP requests", stats.UnitDimensionless)
+	// ShellParseErrors measures the count of errors when attempting to parse shell code.
+	ShellParseErrors = stats.Int64(
+		"ShellParseErrors",
+		"Measures the count of errors when attempting to parse shell code",
+		stats.UnitDimensionless,
+	)
 )

stats/views.go

@@ -88,4 +88,13 @@ var (
 		TagKeys:     []tag.Key{CheckName, RequestTag},
 		Aggregation: view.Count(),
 	}
+
+	// ShellParseErrorCount tracks error count stats for parsing shell code.
+	ShellParseErrorCount = view.View{
+		Name:        "ShellParseErrorCount",
+		Description: "Shell parsing errors",
+		Measure:     ShellParseErrors,
+		TagKeys:     []tag.Key{},
+		Aggregation: view.Count(),
+	}
 )