Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add URL to Release structure #890

Closed
laurentsimon opened this issue Aug 23, 2021 · 1 comment · Fixed by #937 or #938
Closed

Feature: add URL to Release structure #890

laurentsimon opened this issue Aug 23, 2021 · 1 comment · Fixed by #937 or #938
Assignees
@azeemshaikh38
Labels
kind/enhancement New feature or request

Comments

@laurentsimon
Copy link
Contributor

In the Signed-Release check, it would be useful to indicate the url of the non-signed release artifacts. See #887 (comment) for example.

The URL should look like https://github.com/ossf/scorecard/releases/tag/v2.1.2
@laurentsimon laurentsimon added the kind/enhancement New feature or request label Aug 23, 2021
@laurentsimon laurentsimon mentioned this issue Aug 23, 2021
Merged
1 task
@azeemshaikh38 azeemshaikh38 self-assigned this Aug 30, 2021
@azeemshaikh38 azeemshaikh38 linked a pull request Aug 31, 2021 that will close this issue
🌱 Use ListReleases API for BranchProtection check #937
Merged
2 tasks
@laurentsimon laurentsimon reopened this Aug 31, 2021
@laurentsimon
Copy link
Contributor Author

re-opening since #887 (comment) was not addressed. See https://github.com/ossf/scorecard/blob/main/checks/signed_releases.go#L76
Path should be set to r.URL and removed from the message.

azeemshaikh38 pushed a commit that referenced this issue Aug 31, 2021
@azeemsgoogle
Fix #890
d117cbb
@azeemshaikh38 azeemshaikh38 linked a pull request Aug 31, 2021 that will close this issue
🐛 Use release tag URL for path #938
Merged
2 tasks
@azeemshaikh38 azeemshaikh38 mentioned this issue Aug 31, 2021
Merged
2 tasks
azeemshaikh38 added a commit that referenced this issue Aug 31, 2021
@azeemshaikh38 @azeemsgoogle
Fix #890 (#938)
d6ba2cd 
Co-authored-by: Azeem Shaikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azeemshaikh38 azeemshaikh38

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@azeemshaikh38 @laurentsimon