Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixing parsing errors for github workflows #1131

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

ristomcgehee
Copy link
Contributor

@ristomcgehee ristomcgehee commented Oct 14, 2021

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Pinned dependency check fails when non-yaml files are present in .github/workflows. This will fix some of the repos Azeem mentioned in BUG: Parsing errors #839 (comment). I had these lines originally in 🐛 Parsing GitHub Workflows should only happen on yaml files #970, but they were removed in a later PR, most likely inadvertently (merging is hard).

  • What is the new behavior (if this is a feature change)?
    The check for unpinned actions will skip non-yaml files.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chrismcgehee !

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azeemshaikh38 azeemshaikh38 merged commit cf9399a into ossf:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants