-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix the Code review merged by user reference #1272
Conversation
Integration tests success for a92cbdff21f84aa283d0e31eee2908045e511304 |
Integration tests success for 158cc51ae03a54697d731c69ee0945f32efc2416 |
I think this is a draft. Let me know when you need a review. |
Why do you think this is a draft? What else is missing? |
Integration tests failure for 45ddaaf92528d2361f8a84db1f60b7535209ee23 |
I don't see changes to the Code-Review check itself, so I'm assuming it's not aware of the new |
Stale pull request message |
are we ready to submit this PR or is there anything pending here? |
can we add unit tests to verify what the PR fixes? I think we're also missing some checks for previous PR #1272 (comment). |
+1 to adding unit tests. No rush on submitting this PR. Just trying to reduce the number of open issues so wanted to check if this PR can close the linked issue. |
Agreed on the unit tests! |
Stale pull request message |
Integration tests success for |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Fixes the The "Code Review" check seems to reject "reviewed" PRs #1260
What is the new behavior (if this is a feature change)?
Fixes the The "Code Review" check seems to reject "reviewed" PRs #1260
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
None
Other information: