🌱 Restore API quota metrics for the weekly cron job.

[spencerschrock]

What kind of change does this PR introduce?

cron update

• PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

The X-RateLimit-Remaining header value was reported by the githubTransport (e.g. GITHUB_AUTH_TOKEN, GITHUB_TOKEN, or a GITHUB_AUTH_SERVER). This transport isn't used with GitHub Apps so the cron doesn't currently have stats for API quota usage.

What is the new behavior (if this is a feature change)?**

The X-RateLimit-Remaining Record()ing is moved to rateLimitTransport so the value is reported regardless of the kind of token used. This seems like the better place for it anyway.

• Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

TokenIndex is one of the grouping tags for GitHub token view:

scorecard/clients/githubrepo/stats/stats.go

Lines 35 to 42 in 9358843

	// GithubTokens tracks the usage/remaining stats per token per resource-type.
	GithubTokens = view.View{
	Name: "GithubTokens",
	Description: "Token usage/remaining stats for Github API tokens",
	Measure: RemainingTokens,
	TagKeys: []tag.Key{TokenIndex, ResourceType},
	Aggregation: view.LastValue(),
	}

The docs didn't have a clear answer on what happens if one of the TagKeys tags isn't set (the GitHub App transport doesn't set TokenIndex since it's not our code), but the code which groups by sample doesn't seem to care if a tag is missing (they ignore the ok field here).

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

[spencerschrock]

I'm not sure there's a good way of testing this, as the nightly test doesn't export metrics. Welcome to whipping something up if needed.

[codecov]

Codecov Report

Merging #2799 (c513f56) into main (9358843) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2799   +/-   ##
=======================================
  Coverage   49.20%   49.21%           
=======================================
  Files         158      158           
  Lines       11969    11967    -2     
=======================================
  Hits         5889     5889           
+ Misses       5711     5709    -2     
  Partials      369      369           

[azeemshaikh38]

I'm not sure there's a good way of testing this, as the nightly test doesn't export metrics. Welcome to whipping something up if needed.

This is a bug I never got around to fixing - the idea with nightly reporting is that it should be logging these stats (see https://github.com/ossf/scorecard/blob/main/cron/monitoring/printer.go).

[azeemshaikh38]

Thanks