-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upload cron results to a table with new format #830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
force-pushed
the
feat/cron2
branch
from
August 11, 2021 18:40
c8aac19
to
1c008a0
Compare
laurentsimon
commented
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Left some comments.
laurentsimon
force-pushed
the
feat/cron2
branch
from
August 11, 2021 20:25
c016405
to
3bdef43
Compare
azeemshaikh38
approved these changes
Aug 11, 2021
laurentsimon
force-pushed
the
feat/cron2
branch
from
August 12, 2021 23:37
a51da48
to
7c1e2b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
we store cron results in one table using old format only
What is the new behavior (if this is a feature change)?
we store cron results in both the old and new format in 2 tables.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: