Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upload cron results to a table with new format #830

Merged
merged 17 commits into from
Aug 16, 2021

Conversation

laurentsimon
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    we store cron results in one table using old format only

  • What is the new behavior (if this is a feature change)?
    we store cron results in both the old and new format in 2 tables.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

cron/worker/main.go Outdated Show resolved Hide resolved
cron/bq/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Left some comments.

@laurentsimon laurentsimon enabled auto-merge (squash) August 13, 2021 00:24
@laurentsimon laurentsimon merged commit 23764f0 into ossf:main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants