🐛 Add ephemeral-storage to cron worker #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inferno-chromium
approved these changes
Aug 23, 2021
|
Integration tests success for feab9d192e32b29a49bf0f49e737a80c22d53d31 |
There was a problem hiding this comment.
It is the https://kubernetes.io/docs/concepts/storage/volumes/#emptydir that is causing ephemeralstorage to get filled up. I agree with @inferno-chromium we should probably go higher.
azeemshaikh38
force-pushed
the
azeems/storage
branch
from
feab9d1
to
c074b61
Compare
Done. |
That makes more sense. Thanks! |
|
Integration tests success for c074b6119e074c7376afb0c4d6d58ab1e08a7acf |
|
Integration tests success for 78bdc9856db1d2f19e4ca2c02a365c3c4b69cc76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Cron workers were getting evicted since no ephemeral storage was requested. Explicitly requesting ephemeral-storage to avoid this.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.