-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Included race flag to tests #921
Conversation
Integration tests success for 3cbc63f6f6789cdf1212a9dc3179b72b1640d588 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, looks like this is only for unit tests which we don't have many of. Can we enable this setting for e2e
tests as well?
Included the `-race` flag to tests to detect any race conditions. Especially now that we are using the `sync` package.
3cbc63f
to
7e2ed61
Compare
Included that 👍 , Thanks |
Integration tests success for c07cd90b05356c3bb5eb4769857e1cad4e722d84 |
Integration tests success for 7e2ed6148996f4c64b26f4d970e5a38410ce3f74 |
Integration tests success for 89abcf730227ce187da871c1c6b44e4b0159900d |
Integration tests success for f252ffe7952b67e3004b189d3a1fb7127b240da7 |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Included the
-race
flag to tests to detect any race conditions.Especially now that we are using the
sync
package.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: