Skip to content

Commit

Permalink
for bug #248, rename SrsBuffer to SrsFastBuffer.
Browse files Browse the repository at this point in the history
  • Loading branch information
winlinvip committed Dec 4, 2014
1 parent 0ea8cd9 commit 8423974
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 23 deletions.
22 changes: 11 additions & 11 deletions trunk/src/rtmp/srs_protocol_buffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ IMergeReadHandler::~IMergeReadHandler()
{
}

SrsBuffer::SrsBuffer()
SrsFastBuffer::SrsFastBuffer()
{
merged_read = false;
_handler = NULL;
Expand All @@ -85,24 +85,24 @@ SrsBuffer::SrsBuffer()
buffer = new char[nb_buffer];
}

SrsBuffer::~SrsBuffer()
SrsFastBuffer::~SrsFastBuffer()
{
srs_freep(buffer);
}

int SrsBuffer::length()
int SrsFastBuffer::length()
{
int len = (int)data.size();
srs_assert(len >= 0);
return len;
}

char* SrsBuffer::bytes()
char* SrsFastBuffer::bytes()
{
return (length() == 0)? NULL : &data.at(0);
}

void SrsBuffer::erase(int size)
void SrsFastBuffer::erase(int size)
{
if (size <= 0) {
return;
Expand All @@ -116,14 +116,14 @@ void SrsBuffer::erase(int size)
data.erase(data.begin(), data.begin() + size);
}

void SrsBuffer::append(const char* bytes, int size)
void SrsFastBuffer::append(const char* bytes, int size)
{
srs_assert(size > 0);

data.insert(data.end(), bytes, bytes + size);
}

int SrsBuffer::grow(ISrsBufferReader* reader, int required_size)
int SrsFastBuffer::grow(ISrsBufferReader* reader, int required_size)
{
int ret = ERROR_SUCCESS;

Expand Down Expand Up @@ -156,7 +156,7 @@ int SrsBuffer::grow(ISrsBufferReader* reader, int required_size)
return ret;
}

void SrsBuffer::set_merge_read(bool v, int max_buffer, IMergeReadHandler* handler)
void SrsFastBuffer::set_merge_read(bool v, int max_buffer, IMergeReadHandler* handler)
{
merged_read = v;
_handler = handler;
Expand All @@ -173,7 +173,7 @@ void SrsBuffer::set_merge_read(bool v, int max_buffer, IMergeReadHandler* handle
}
}

void SrsBuffer::on_chunk_size(int32_t chunk_size)
void SrsFastBuffer::on_chunk_size(int32_t chunk_size)
{
if (nb_buffer >= chunk_size) {
return;
Expand All @@ -191,12 +191,12 @@ void SrsBuffer::on_chunk_size(int32_t chunk_size)
}
}

int SrsBuffer::buffer_size()
int SrsFastBuffer::buffer_size()
{
return nb_buffer;
}

void SrsBuffer::reset_buffer(int size)
void SrsFastBuffer::reset_buffer(int size)
{
srs_freep(buffer);

Expand Down
6 changes: 3 additions & 3 deletions trunk/src/rtmp/srs_protocol_buffer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class IMergeReadHandler
* the buffer provices bytes cache for protocol. generally,
* protocol recv data from socket, put into buffer, decode to RTMP message.
*/
class SrsBuffer
class SrsFastBuffer
{
private:
// the merged handler
Expand All @@ -121,8 +121,8 @@ class SrsBuffer
char* buffer;
int nb_buffer;
public:
SrsBuffer();
virtual ~SrsBuffer();
SrsFastBuffer();
virtual ~SrsFastBuffer();
public:
/**
* get the length of buffer. empty if zero.
Expand Down
2 changes: 1 addition & 1 deletion trunk/src/rtmp/srs_protocol_stack.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ SrsProtocol::AckWindowSize::AckWindowSize()

SrsProtocol::SrsProtocol(ISrsProtocolReaderWriter* io)
{
in_buffer = new SrsBuffer();
in_buffer = new SrsFastBuffer();
skt = io;

in_chunk_size = SRS_CONSTS_RTMP_PROTOCOL_CHUNK_SIZE;
Expand Down
4 changes: 2 additions & 2 deletions trunk/src/rtmp/srs_protocol_stack.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
#include <srs_kernel_consts.hpp>

class ISrsProtocolReaderWriter;
class SrsBuffer;
class SrsFastBuffer;
class SrsPacket;
class SrsStream;
class SrsAmf0Object;
Expand Down Expand Up @@ -206,7 +206,7 @@ class SrsProtocol
/**
* bytes buffer cache, recv from skt, provide services for stream.
*/
SrsBuffer* in_buffer;
SrsFastBuffer* in_buffer;
/**
* input chunk size, default to 128, set by peer packet.
*/
Expand Down
8 changes: 4 additions & 4 deletions trunk/src/utest/srs_utest_kernel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -203,15 +203,15 @@ int MockBufferReader::read(void* buf, size_t size, ssize_t* nread)

VOID TEST(KernelBufferTest, DefaultObject)
{
SrsBuffer b;
SrsFastBuffer b;

EXPECT_EQ(0, b.length());
EXPECT_EQ(NULL, b.bytes());
}

VOID TEST(KernelBufferTest, AppendBytes)
{
SrsBuffer b;
SrsFastBuffer b;

char winlin[] = "winlin";
b.append(winlin, strlen(winlin));
Expand All @@ -231,7 +231,7 @@ VOID TEST(KernelBufferTest, AppendBytes)

VOID TEST(KernelBufferTest, EraseBytes)
{
SrsBuffer b;
SrsFastBuffer b;

b.erase(0);
b.erase(-1);
Expand Down Expand Up @@ -267,7 +267,7 @@ VOID TEST(KernelBufferTest, EraseBytes)

VOID TEST(KernelBufferTest, Grow)
{
SrsBuffer b;
SrsFastBuffer b;
MockBufferReader r("winlin");

b.grow(&r, 1);
Expand Down
4 changes: 2 additions & 2 deletions trunk/src/utest/srs_utest_protocol.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ class MockBufferIO : public ISrsProtocolReaderWriter
int64_t recv_bytes;
int64_t send_bytes;
// data source for socket read.
SrsBuffer in_buffer;
SrsFastBuffer in_buffer;
// data buffer for socket send.
SrsBuffer out_buffer;
SrsFastBuffer out_buffer;
public:
MockBufferIO();
virtual ~MockBufferIO();
Expand Down

0 comments on commit 8423974

Please sign in to comment.