Enhancement: Add param and stream to on_connect #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add stream and param to hook call on_connect for better use
|
Could you please review this pr and merge into master if possible? @winlinvip |
winlinvip
force-pushed
the
3.0release
branch
28 times, most recently
from
3c0fc9b
to
ccd8c86
Compare
winlinvip
force-pushed
the
3.0release
branch
3 times, most recently
from
1ca9308
to
8d44b98
Compare
winlinvip
reviewed
Aug 28, 2021
| @@ -70,6 +70,8 @@ srs_error_t SrsHttpHooks::on_connect(string url, SrsRequest* req) | |||
| obj->set("ip", SrsJsonAny::str(req->ip.c_str())); | |||
| obj->set("vhost", SrsJsonAny::str(req->vhost.c_str())); | |||
| obj->set("app", SrsJsonAny::str(req->app.c_str())); | |||
| obj->set("stream", SrsJsonAny::str(req->stream.c_str())); | |||
There was a problem hiding this comment.
stream does not have a value in on_connect, right? It only has a value when play or publish occurs.
However, adding it is also possible, but it may be an empty value.
TRANS_BY_GPT3
There was a problem hiding this comment.
Yeah, you can note that in the documentation that this may be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stream and param to hook call on_connect for better use