Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kickoff publisher when stream is idle, which means no players. v6.0.31, v5.0.144 #3105

Merged
merged 9 commits into from
Mar 6, 2023

Conversation

industriousonesoft
Copy link
Contributor

@industriousonesoft industriousonesoft commented Jul 10, 2022

For some use scenario, the publisher is invited when player want to view the stream:

  1. Publisher connect to system, but does not publish any stream to SRS yet.
  2. Player connect to system and start to request the stream.
  3. System notifies publisher to publish stream to SRS.
  4. Player play the stream from SRS.

Please notice that system means your business system, not SRS.

This is what we called on-demand-live-streaming, so when the last player stop to view the stream, what happends?

  1. System needs to notify publisher to stop publish.
  2. Or, SRS disconnect the publisher when idle(the last player stops playing).

This PR is for the solution 2, so that the cleanup is very simple, your system does not need to notify publisher to stop publish, because SRS has already disconnected the publihser.

@winlinvip winlinvip force-pushed the develop branch 25 times, most recently from be660c8 to 1fe12b8 Compare August 14, 2022 14:41
@winlinvip winlinvip changed the title 支持无人观看的情况下,超时自动踢流功能。 Kickoff publisher when stream is idle, which means no consumers or players. Feb 25, 2023
@winlinvip winlinvip changed the title Kickoff publisher when stream is idle, which means no consumers or players. Kickoff publisher when stream is idle, which means no players. Mar 4, 2023
@winlinvip winlinvip added the ReadyToMerge Can be merged with the final review. label Mar 4, 2023
@winlinvip
Copy link
Member

This PR is part of #3420

@winlinvip winlinvip changed the title Kickoff publisher when stream is idle, which means no players. Kickoff publisher when stream is idle, which means no players. v6.0.31, v5.0.144 Mar 6, 2023
@winlinvip winlinvip merged commit 8fde036 into ossrs:develop Mar 6, 2023
winlinvip added a commit that referenced this pull request Mar 6, 2023
…1, v5.0.144 (#3105)

For some use scenario, the publisher is invited when player want to view the stream:

1. Publisher connect to system, but does not publish any stream to SRS yet.
2. Player connect to system and start to request the stream.
3. System notifies publisher to publish stream to SRS.
4. Player play the stream from SRS.

Please notice that `system` means your business system, not SRS.

This is what we called `on-demand-live-streaming`, so when the last player stop to view the stream, what happends?

1. System needs to notify publisher to stop publish.
2. Or, SRS disconnect the publisher when idle(the last player stops playing).

This PR is for the solution 2, so that the cleanup is very simple, your system does not need to notify publisher to stop publish, because SRS has already disconnected the publihser.

PICK 8fde036

---------

Co-authored-by: winlin <[email protected]>
Co-authored-by: chundonglinlin <[email protected]>
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToMerge Can be merged with the final review. TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants