Edge: Improve stability for state and fd closing. v5.0.214 v6.0.139

[winlinvip]

1. Should always stop coroutine before close fd, see Edge pull, the system often encounters errors ret=1018 (Device or resource busy) and ret=1018 (No such file or directory). #511, When the SrsHttpApi object is destructed, the program encounters a coredump, caused by srs_close_stfd. #1784
2. When edge forwarder coroutine quit, always set the error code.
3. Do not unpublish if invalid state.

---

Co-authored-by: Jacob Su [email protected]

[suzp1984]

review send_error_code problem.

[suzp1984]

Suggested change

	if (send_error_code == 0) {
	if ((err = do_cycle()) != srs_success) {
	if (send_error_code == ERROR_SUCCESS) {
	// If coroutine stopping, we should always set the quit error code.
	send_error_code = srs_error_code(err);
	}
	return srs_error_wrap(err, "do cycle");
	}

suggest another way.

About send_error_code, I believe there is a dead loop:

srs/trunk/src/app/srs_app_edge.cpp

Lines 864 to 884 in 8c034e5

	while (true) {
	if ((err = trd->pull()) != srs_success) {
	return srs_error_wrap(err, "edge forward pull");
	}
	if (send_error_code != ERROR_SUCCESS) {
	srs_usleep(SRS_EDGE_FORWARDER_TIMEOUT);
	continue;
	}
	// read from client.
	if (true) {
	SrsCommonMessage* msg = NULL;
	err = sdk->recv_message(&msg);
	if (err != srs_success && srs_error_code(err) != ERROR_SOCKET_TIMEOUT) {
	srs_error("edge push get server control message failed. err=%s", srs_error_desc(err).c_str());
	send_error_code = srs_error_code(err);
	srs_error_reset(err);
	continue;
	}

there are no place to set send_error_code = ERROR_SUCCESS in the loop, only set the value when sdk->recv_message(&msg).

[winlinvip]

not dead loop, the publish owner will stop it when error.