Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support typescript-eslint@8 #333

Merged
merged 3 commits into from
Sep 12, 2024
Merged

fix: support typescript-eslint@8 #333

merged 3 commits into from
Sep 12, 2024
+8 −3

Conversation

JoshuaKGoldberg
Copy link
Contributor

Fixes #332

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9efa0c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-eslint-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoshuaKGoldberg
Copy link
Contributor Author

JoshuaKGoldberg commented Sep 12, 2024 •
edited
Loading

CI lint failures are pre-existing and unrelated. Filed #334 and fixed in #335.

CI test failures are pre-existing and unrelated. Filed #336 and fixed in #337.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft September 12, 2024 13:40
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 12, 2024 13:54
ota-meshi
ota-meshi approved these changes Sep 12, 2024
View reviewed changes
Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@ota-meshi ota-meshi merged commit 9f4526e into ota-meshi:main Sep 12, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Merged
@JoshuaKGoldberg JoshuaKGoldberg deleted the tseslint-8 branch September 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support typescript-eslint@8?
2 participants
@JoshuaKGoldberg @ota-meshi