ji-2771 submit button

[thomasmars]

No description provided.

[otacke]

@thomasmars
What's this used for? I found https://github.com/h5p/h5p-question/blob/ji-2771-submit-button/scripts/question.js#L1279-L1284 and it seems the button label is becoming kind of dynamic? Regular label if "scoring" or "reporting" are set in the latest changes to H5PIntegration - otherwise "Submit". I assume for letting users know that their answers will be sent to the host platform? If so, will it be clear enough that the button also will check their answer and show them a result? So hard to say, since JI-2771 is not a public ticket and I don't know what has been discussed.

I'll accept this change, of course, but I'll gladly update my repositories myself if there's some new feature that should be supported - just added support for the new audio option in H5P.Question, too.

[thomasmars]

@otacke Yes, that is correct, it allows h5p core to send in whether the results will be submitted to external services or reporting, and if that is the case the button text will be "Submit" instead, to signal that you are submitting, instead of just checking your answers.

[otacke]

@thomasmars Glad I had figured that out correctly :-D Let's see if this will confuse people or not. "Check & submit" might be an alternative, but is quite long (and may be even longer in other languages) and it makes sense to have this in a uniform way across content types. Will check and merge in a sec.

[icc]

Thank you

[otacke]

@thomasmars @icc Make that second a little longer :-) I merged in the pull requests for the other content types, but I am still waiting for confirmation by LTC. Technically, it's their content type although it's in my repository.