Added sdputils.js from AppRTC project

[janswee]

sdputilsjs includes more custom control configuration of video/audio codec and bitrate in offer function.

Please refer to https://github.com/webrtc/apprtc/blob/master/src/web_app/js/sdputils.js

[tgabi333]

I'm not sure what is it is for?

[janswee]

sdputils.js is a collection of utility functions to munge/manipulate SDP offer.

One valid use case is setting a video codec preference of VP9 over VP8. VP9 requires less bandwidth/processing than VP8.

Using SimpleWebRTC, one can then set their video codec preference in the config object like so:

params: {
   videoRecvCodec: webrtcSupport.supportVp9 ? 'VP9' : 'VP8'
}

and then used in the RTCPeerConnection.offer function like so:

            //from AppRTC PeerConnectionClient.prototype.setLocalSdpAndNotify_() using sdputils.js
            offer.sdp = sdputils.maybePreferAudioReceiveCodec(offer.sdp, self.params_);
            offer.sdp = sdputils.maybePreferVideoReceiveCodec(offer.sdp, self.params_);
            offer.sdp = sdputils.maybeSetAudioReceiveBitRate(offer.sdp, self.params_);
            offer.sdp = sdputils.maybeSetVideoReceiveBitRate(offer.sdp, self.params_);
            offer.sdp = sdputils.maybeRemoveVideoFec(offer.sdp, self.params_);

[fippo]

SDP munging between createOffer and setLocalDescription is no longer valid in the spec.

If you want to do this I would suggest doing munging before signaling which makes it a non-issue for this library.

[janswee]

Thanks, will leave it for now. If you have a link to spec change, it would great. Cheers. On Jun 27, 2019, at 8:19 AM, Philipp Hancke <[email protected]<mailto:[email protected]>> wrote: SDP munging between createOffer and setLocalDescription is no longer valid in the spec. If you want to do this I would suggest doing munging before signaling which makes it a non-issue for this library. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#103?email_source=notifications&email_token=AB4H7Q3GVVVNBEPK3XF55YTP4TLAHA5CNFSM4H3YCZ6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXOTKQ#issuecomment-506390954>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB4H7QZ4NODLLT7GNAJ6IF3P4TLAHANCNFSM4H3YCZ6A>.