Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari 11 bugfix: usage of promise-based version for pc.createOffer #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lawlietmester
Copy link

@lawlietmester lawlietmester commented Jun 7, 2018

Initial bug: https://github.com/andyet/SimpleWebRTC/issues/704

In case of callback-based version of .createOffer Safari 11.0.3 perceives mediaConstraints always as

{
  'offerToReceiveAudio': false,
  'offerToReceiveVideo': false
}

But in case of promise-based version it perceives mediaConstraints as intended.

@fippo
Copy link
Member

fippo commented Jun 7, 2018

that actually sounds like a bug in adapter.

I made #98 using https://github.com/fippo/webrtc-codemods to use promises instead of the legacy version in all relevant calls

@lawlietmester
Copy link
Author

@fippo Maybe, but https://github.com/webrtc/adapter/issues/685

Safari support will most likely be added once it's more stable and supporting API's are in place.

So in fact they are not supporting it

@fippo
Copy link
Member

fippo commented Jun 7, 2018

no, adapter shims the legacy offerToReceive constraints. I am just surprised this would not work in the callback version -- even though that should simply not be used anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants