Add support for native promises #28
Conversation
| var originalThen = Promise.prototype.then | ||
| Promise.prototype.then = wrappedThen | ||
|
|
||
| function wrappedThen() { |
There was a problem hiding this comment.
this is a SyntaxError in node 0.11.16
There was a problem hiding this comment.
oh interesting, I guess v8 strict mode has changed a bit between iojs 1.0.4 and 0.11.16
There was a problem hiding this comment.
I think since block scoping is on by default, having function declarations inside if is ok
|
I added a few more tests, and everything seems to be working as expected. One thing I have not figured out is how to detect native promises vs some shim. It is native code so toString will hint at that, but its not really any different than if you call .bind on a non native function. Anyone have thoughts on this? |
|
Okay, I think detection for native promises is now pretty good, and all of the Promise methods are now tested, found a couple that are not in the spec or documented anywhere. |
|
What's the status of this? From what I've been able to figure out, getting this PR merged is key to using CLS with Koa. |
|
Should be good to go, just waiting on someone to review it
|
| } | ||
| } | ||
|
|
||
| wrap(Promise.prototype, 'then', wrapThen) |
There was a problem hiding this comment.
Not needed, catch appears to call then
| @@ -0,0 +1,619 @@ | |||
| if (!global.Promise) return; | |||
There was a problem hiding this comment.
Are there any versions of node/io that might be broken in their promise support because of half baked implementations? Such as 0.11 with --harmony, if so, do we care?
There was a problem hiding this comment.
none without flags. Not sure if we care about flags, but the instrumentation is pretty straight forward, unless they were completely different, I don't see this being an issue.
|
👍 |
|
LGTM. I'd add a comment explaining the logic behind the weird interaction between resolve/reject and then calls though. It might be somewhat non-obvious what all this does to someone looking at the code in the future. |
This tries to implement what was discussed in #25