Allow "#{hash["key"]}" literal

otoyo · Nov 20, 2021 · 52fa8e8 · 52fa8e8
1 parent 0627973
commit 52fa8e8
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/lib/i18n/tasks/scanners/ruby_key_literals.rb b/lib/i18n/tasks/scanners/ruby_key_literals.rb
@@ -2,10 +2,10 @@
 
 module I18n::Tasks::Scanners
   module RubyKeyLiterals
-    LITERAL_RE = /:?".+?"|:?'.+?'|:\w+/.freeze
+    LITERAL_RE = /:?"[\[]*(?:\[\s*")?.+(?:"\s*\])?"|:?'.+?'|:\w+/.freeze
 
     # Match literals:
-    # * String: '', "#{}"
+    # * String: '', "#{}", "#{hash["key"]}"
     # * Symbol: :sym, :'', :"#{}"
     def literal_re
       LITERAL_RE

diff --git a/spec/scanners/ruby_key_literals_spec.rb b/spec/scanners/ruby_key_literals_spec.rb
@@ -21,8 +21,27 @@
       end
 
       context 'double quoted' do
-        let(:key) { %q("#{some_key}") } # rubocop:disable Lint/InterpolationCheck
-        it { is_expected.to eq(key) }
+        context 'var' do
+          let(:key) { %q("#{some_key}") } # rubocop:disable Lint/InterpolationCheck
+          it { is_expected.to eq(key) }
+        end
+
+        context 'hash' do
+          context 'double quoted key' do
+            let(:key) { %q("#{some_hash["some_key"]}") } # rubocop:disable Lint/InterpolationCheck
+            it { is_expected.to eq(key) }
+          end
+
+          context 'single quoted key' do
+            let(:key) { %q("#{some_hash['some_key']}") } # rubocop:disable Lint/InterpolationCheck
+            it { is_expected.to eq(key) }
+          end
+
+          context 'symbol key' do
+            let(:key) { %q("#{some_hash[:some_key]}") } # rubocop:disable Lint/InterpolationCheck
+            it { is_expected.to eq(key) }
+          end
+        end
       end
     end