Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Path For Tests #11

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

AksharP5
Copy link
Collaborator

@AksharP5 AksharP5 commented Mar 14, 2024

Template for Final Squash Commit Message

fix: run tests anywhere, and fix ABC test

Tests can now be ran no matter where you are located.
ABC now checks against two different expected outputs.

---

* Closes #10 

---

@AksharP5 AksharP5 self-assigned this Mar 14, 2024
@AksharP5
Copy link
Collaborator Author

Closes #10

@AksharP5 AksharP5 force-pushed the akshar5/tests-not-able-to-be-ran-10 branch from b68ef29 to 100210f Compare March 14, 2024 14:11
@AksharP5
Copy link
Collaborator Author

AksharP5 commented Mar 14, 2024

@StoneyJackson the ABC test issue should be resolved now, I have squashed and set a single commit, you can leave a comment with a better commit message and I will squash again if you do not agree with the one I have written, and this should be merged into main to fix the plcc testing issue when you clone languages. I have tested it using a PR in the plcc repo, which I have closed, and it worked as expected. This also fixes the issue of tests not being able to be ran when you are not located in the languages repo.

@AksharP5 AksharP5 force-pushed the akshar5/tests-not-able-to-be-ran-10 branch from 7524064 to d6312e2 Compare March 15, 2024 18:01
@AksharP5
Copy link
Collaborator Author

Added a second expected file to check against, as the ABC test can produce output in two different orders, but the issue should now be resolved, tested this feature branch in plcc and the tests passed, and they also pass in here.

@AksharP5 AksharP5 force-pushed the akshar5/tests-not-able-to-be-ran-10 branch 2 times, most recently from 3e382c4 to b2eb5a9 Compare March 25, 2024 13:24
@AksharP5
Copy link
Collaborator Author

Using 'git rev-parse --show-toplevel' to cd into root of languages repo, which allows for the second cd of each test to run properly without any errors when ran from anywhere, and I have tested this by cloning this repo into plcc and switching to this feature branch, and attempting to run tests from anywhere, and everything is functioning as expected.

@AksharP5 AksharP5 force-pushed the akshar5/tests-not-able-to-be-ran-10 branch 2 times, most recently from 3461520 to 89d5da6 Compare March 27, 2024 17:33
Tests can now be ran no matter where you are located.
ABC now checks against two different expected outputs.

---

* Closes #10

---
@AksharP5 AksharP5 force-pushed the akshar5/tests-not-able-to-be-ran-10 branch from 89d5da6 to 1b7857b Compare March 27, 2024 17:43
@StoneyJackson StoneyJackson merged commit 7efcbc7 into main Mar 27, 2024
@StoneyJackson StoneyJackson deleted the akshar5/tests-not-able-to-be-ran-10 branch March 27, 2024 17:45
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants