-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Path For Tests #11
Conversation
Closes #10 |
b68ef29
to
100210f
Compare
@StoneyJackson the ABC test issue should be resolved now, I have squashed and set a single commit, you can leave a comment with a better commit message and I will squash again if you do not agree with the one I have written, and this should be merged into main to fix the plcc testing issue when you clone languages. I have tested it using a PR in the plcc repo, which I have closed, and it worked as expected. This also fixes the issue of tests not being able to be ran when you are not located in the languages repo. |
7524064
to
d6312e2
Compare
Added a second expected file to check against, as the ABC test can produce output in two different orders, but the issue should now be resolved, tested this feature branch in plcc and the tests passed, and they also pass in here. |
3e382c4
to
b2eb5a9
Compare
Using 'git rev-parse --show-toplevel' to cd into root of languages repo, which allows for the second cd of each test to run properly without any errors when ran from anywhere, and I have tested this by cloning this repo into plcc and switching to this feature branch, and attempting to run tests from anywhere, and everything is functioning as expected. |
3461520
to
89d5da6
Compare
Tests can now be ran no matter where you are located. ABC now checks against two different expected outputs. --- * Closes #10 ---
89d5da6
to
1b7857b
Compare
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Template for Final Squash Commit Message