Skip to content

Commit

Permalink
Sharing tsconfig across packages (#359)
Browse files Browse the repository at this point in the history
* wip on shared tsconfig

* update to use shared tsconfig

* adding missing config
  • Loading branch information
oveddan authored and kulkarohan committed Dec 8, 2023
1 parent 765d030 commit 7e7702e
Show file tree
Hide file tree
Showing 9 changed files with 39 additions and 53 deletions.
3 changes: 2 additions & 1 deletion packages/1155-contracts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"prettier-plugin-solidity": "^1.1.3",
"@types/node": "^20.1.2",
"tsup": "^7.2.0",
"typescript": "^5.0.4"
"zoralabs-tsconfig": "*",
"typescript": "^5.2.2"
}
}
18 changes: 1 addition & 17 deletions packages/1155-contracts/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,23 +1,7 @@
{
"extends": "zoralabs-tsconfig/tsconfig.json",
"compilerOptions": {
"allowJs": true,
"baseUrl": ".",
"downlevelIteration": true,
"esModuleInterop": true,
"isolatedModules": true,
"lib": ["es2021"],
"module": "esnext",
"moduleResolution": "node",
"noImplicitAny": true,
"noUncheckedIndexedAccess": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"strict": true,
"strictNullChecks": true,
"target": "es2021",
"types": ["node"],
"outDir": "dist"
},
"exclude": ["node_modules/**", "dist/**"],
Expand Down
1 change: 1 addition & 0 deletions packages/protocol-deployments/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"solady": "^0.0.132",
"tsup": "^7.2.0",
"tsx": "^3.13.0",
"zoralabs-tsconfig": "*",
"typescript": "^5.2.2"
}
}
18 changes: 1 addition & 17 deletions packages/protocol-deployments/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,23 +1,7 @@
{
"extends": "zoralabs-tsconfig/tsconfig.json",
"compilerOptions": {
"allowJs": true,
"baseUrl": ".",
"downlevelIteration": true,
"esModuleInterop": true,
"isolatedModules": true,
"lib": ["es2021"],
"module": "esnext",
"moduleResolution": "node",
"noImplicitAny": true,
"noUncheckedIndexedAccess": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"strict": true,
"strictNullChecks": true,
"target": "es2021",
"types": ["node"],
"outDir": "dist"
},
"exclude": ["node_modules/**", "dist/**"],
Expand Down
1 change: 1 addition & 0 deletions packages/protocol-sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"viem": "^1.16.6"
},
"devDependencies": {
"zoralabs-tsconfig": "*",
"typescript": "^5.2.2",
"vite": "4.5.0",
"vitest": "0.34.6"
Expand Down
19 changes: 2 additions & 17 deletions packages/protocol-sdk/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,23 +1,8 @@
{
"extends": "zoralabs-tsconfig/tsconfig.json",
"compilerOptions": {
"allowJs": true,
"baseUrl": ".",
"downlevelIteration": true,
"esModuleInterop": true,
"isolatedModules": true,
"lib": ["es2021", "DOM"],
"module": "esnext",
"moduleResolution": "node",
"noImplicitAny": true,
"noUncheckedIndexedAccess": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"strict": true,
"strictNullChecks": true,
"target": "es2021",
"types": ["node"],
"baseUrl": ".",
"outDir": "dist"
},
"exclude": ["node_modules/**", "dist/**"],
Expand Down
9 changes: 9 additions & 0 deletions packages/tsconfig/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"name": "zoralabs-tsconfig",
"version": "0.0.0",
"private": true,
"license": "MIT",
"publishConfig": {
"access": "public"
}
}
21 changes: 21 additions & 0 deletions packages/tsconfig/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"compilerOptions": {
"allowJs": true,
"downlevelIteration": true,
"esModuleInterop": true,
"isolatedModules": true,
"lib": ["es2021"],
"module": "esnext",
"moduleResolution": "node",
"noImplicitAny": true,
"noUncheckedIndexedAccess": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"strict": true,
"strictNullChecks": true,
"target": "es2021",
"types": ["node"]
}
}
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3994,7 +3994,7 @@ [email protected]:
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.1.6.tgz#02f8ac202b6dad2c0dd5e0913745b47a37998274"
integrity sha512-zaWCozRZ6DLEWAWFrVDz1H6FVXzUSfTy5FUMWsQlU8Ym5JP9eO4xkTIROFCQvhQf61z6O/G6ugw3SgAnvvm+HA==

typescript@^5.0.4, typescript@^5.2.2:
typescript@^5.2.2:
version "5.2.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.2.2.tgz#5ebb5e5a5b75f085f22bc3f8460fba308310fa78"
integrity sha512-mI4WrpHsbCIcwT9cF4FZvr80QUeKvsUsUvKDoR+X/7XHQH98xYD8YHZg7ANtz2GtZt/CBq2QJ0thkGJMHfqc1w==
Expand Down

0 comments on commit 7e7702e

Please sign in to comment.