Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include package.json in cache keys when building solidity in CI #381

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 21, 2023

we want to do this so that the dependent contract versions affect the cache, for when contracts are imported via npm by version; if an npm dependency changes, this would result in a new cache key

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 21, 2023

Merge activity

  • Nov 20, 9:29 PM: @oveddan started a stack merge that includes this pull request via Graphite.
  • Nov 20, 9:29 PM: @oveddan merged this pull request with Graphite.

@oveddan oveddan merged commit 453c869 into main Nov 21, 2023
10 checks passed
iainnash pushed a commit that referenced this pull request Jan 5, 2024
we want to do this so that the dependent contract versions affect the cache, for when contracts are imported via npm by version; if an npm dependency changes, this would result in a new cache key
iainnash pushed a commit that referenced this pull request Jan 11, 2024
we want to do this so that the dependent contract versions affect the cache, for when contracts are imported via npm by version; if an npm dependency changes, this would result in a new cache key
iainnash pushed a commit that referenced this pull request Jan 11, 2024
we want to do this so that the dependent contract versions affect the cache, for when contracts are imported via npm by version; if an npm dependency changes, this would result in a new cache key
@iainnash iainnash deleted the use-package.json-for-cache branch January 11, 2024 15:37
oveddan pushed a commit that referenced this pull request Jun 4, 2024
* Remove mints deployments from package deps on 1155-deployments.

* update import paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant