[Assignment #2] Convert to a plugin #54

pruett · 2015-03-19T16:58:27Z

Reference issue #43

AdriVanHoudt · 2015-03-19T19:19:22Z

lib/index.js

-                return reply({ version: Package.version });
-            }
-        }
+        Hoek.assert(!err, err);
    });

    server.start(function (err) {


you are starting your server without being sure the plugin is fully registered, take a look at it

hueniverse · 2015-03-23T07:37:48Z

lib/version.js

+    return next();
+};
+
+exports.register.attributes = { name: 'versionRoute' };


Cleaner to put object on multiple lines.

hueniverse · 2015-03-23T07:38:00Z

See general comments on issue.

AdriVanHoudt reviewed Mar 19, 2015
View reviewed changes

pruett added 2 commits March 19, 2015 17:18

break out route into plugin

a760233

bump version number

5a1cd80

hueniverse added the submission label Mar 23, 2015

hueniverse added this to the 0.0.2 milestone Mar 23, 2015

hueniverse reviewed Mar 23, 2015
View reviewed changes

lib/version.js

return next();

};

exports.register.attributes = { name: 'versionRoute' };

Copy link

hueniverse Mar 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner to put object on multiple lines.

hueniverse closed this Mar 24, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Assignment #2] Convert to a plugin #54

[Assignment #2] Convert to a plugin #54

pruett commented Mar 19, 2015

AdriVanHoudt Mar 19, 2015

hueniverse Mar 23, 2015

hueniverse commented Mar 23, 2015

[Assignment #2] Convert to a plugin #54

[Assignment #2] Convert to a plugin #54

Conversation

pruett commented Mar 19, 2015

AdriVanHoudt Mar 19, 2015

Choose a reason for hiding this comment

hueniverse Mar 23, 2015

Choose a reason for hiding this comment

hueniverse commented Mar 23, 2015