This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 194
Move route version into its own plugin. #61
Closed
Closed
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,29 +2,22 @@ | |
|
||
var Hapi = require('hapi'); | ||
var Hoek = require('hoek'); | ||
var Package = require('../package.json'); | ||
|
||
|
||
// Declare internals | ||
|
||
var internals = {}; | ||
var internals = { | ||
version: require('./version') | ||
}; | ||
|
||
|
||
internals.init = function () { | ||
|
||
var server = new Hapi.Server(); | ||
server.connection({ port: 8000 }); | ||
|
||
server.route({ | ||
method: 'GET', | ||
path: '/version', | ||
config: { | ||
description: 'Returns the version of the server', | ||
handler: function (request, reply) { | ||
server.register(internals.version, function (err) { | ||
|
||
return reply({ version: Package.version }); | ||
} | ||
} | ||
Hoek.assert(!err,err); | ||
}); | ||
|
||
server.start(function (err) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you should start your server after the plugins have been registered. it needs to be placed in the server.register callback. |
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
var Package = require('../package'); | ||
|
||
var internals = { | ||
response: { | ||
version: Package.version | ||
} | ||
}; | ||
|
||
exports.register = function (server, options, next) { | ||
|
||
server.route({ | ||
method: 'GET', | ||
path: '/version', | ||
handler: function(request, reply) { | ||
|
||
return reply(internals.response.version); | ||
} | ||
}); | ||
|
||
return next(); | ||
}; | ||
|
||
exports.register.attributes = { | ||
name: 'version' | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a module you should assign it to
Version
and then register it