Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scala-collection-compat for Scala Native #592

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Jun 4, 2024

scala-collection-compat was declared with %% which doesn't carry the .nir files necessary for Scala Native.
Moreover, it was always added since the correct switch should be scalaVersion.startsWith("2.12.") not !scalaVersion.startsWith("3.0")

Workaround

Until this gets merged and published you can exclude the wrong scala-collection-compat artifact and manually add the correct version to your libraryDependencies

libraryDependencies ++= Seq(
  ("com.outr" %%% "scribe" % "3.14.0")
    .excludeAll("org.scala-lang.modules" %% "scala-collection-compat")
)

libraryDependencies ++= (
  if (scalaVersion.value.startsWith("2.12.")) {
    List("org.scala-lang.modules" %%% "scala-collection-compat" % "2.12.0")
  } else {
    Nil
  }
)

@lolgab lolgab changed the title Fix scala-collection-compat for Scala Native Fix scala-collection-compat for Scala Native Jun 4, 2024
@darkfrog26 darkfrog26 marked this pull request as ready for review June 4, 2024 14:20
@darkfrog26 darkfrog26 merged commit bc7bdea into outr:master Jun 4, 2024
1 of 2 checks passed
@lolgab lolgab deleted the fix-collection-compat branch June 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants