Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiple feature-gates arguments for the csi-provisioner #810

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

yacinebbt
Copy link
Contributor

Is this a bug fix or adding new feature?
It can be a bug fix or a new feature, it's up to you to decide how to name it.

What is this PR about? / Why do we need it?

What?

When i want to enable a feature gate and specify it to be used by the provisioner, everytime i need to deploy the helm chart then edit the csi-controller deployment by adding the args needed.

        - name: csi-provisioner
          image: registry.k8s.io/sig-storage/csi-provisioner:v3.0.0
          args:
            - '--csi-address=$(ADDRESS)'
            - '--feature-gates=Topology=true'
            - '--feature-gates=Key=Value'

Why?
To make it possible for users to controll which extra feature gates or extra arguments in general to enable using the helm chart, without the need of doing that manually after the deployment everytime.

What testing is done?

Simply deploy a helm chart and try to enable a feature gate of your choice automatically, you'll not find where to specify your argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants