-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bun install 60% faster on Windows, improve reliability, reduce memory usage #10037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ @Jarred-Sumner 3 files with test failures on linux-x64: |
❌ @Jarred-Sumner 2 files with test failures on bun-darwin-aarch64:
|
❌ @Jarred-Sumner 4 files with test failures on linux-x64-baseline: |
❌ @Jarred-Sumner 3 files with test failures on bun-darwin-x64:
|
…e call runTasks on every event loop wakeup.
❌ @Jarred-Sumner 9 files with test failures on bun-windows-x86_64-haswell
|
Jarred-Sumner
changed the title
[bundows] Make bun install 60% faster
[bundows] Make bun install 60% faster, improve reliability, reduce memory usage
Apr 8, 2024
Jarred-Sumner
changed the title
[bundows] Make bun install 60% faster, improve reliability, reduce memory usage
Make bun install 60% faster on Windows, improve reliability, reduce memory usage
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the synchronization primitives used by bun install from using Go-like channels to instead use an unbounded mpmc queue with large pre-allocated contiguous structs that are recycled (only dynamically allocated when pre-allocated space runs out).
This fixes deadlocks that can occur when many different packages finish extracting simultaneously when the main thread goes to sleep.
This closes node_modules folders when there are async tasks, which fixes #10039.
On Windows, this makes
installWithHardlinks
run concurrently, which offers a 60% performance boost to cached installs.Fixes #4066
Fixes #5142
How did you verify your code works?
CI