update zig to 0.11.0 #4233

CGQAQ · 2023-08-21T08:49:20Z

What does this PR do?

This PR includes:

update zig to 0.11.0 ( 0.12 as of now 0.12.0-dev.161+6a5463951 works as well though)
fix several memory deallocating mismatches with allocating function issues
fix the build script to make it works on the latest zig compiler
change jsonStringify signature to make it works on the latest zig compiler

Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

How did you verify your code works?

I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
I or my editor ran zig fmt on the changed files
I included a test for the new code, or an existing test covers it
JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed

Thanks to @Hanaasagi , @ianprime0509 and @mlugg for helping me out

Jarred-Sumner · 2023-08-21T09:03:10Z

Thank you for starting this

To fix the jsonStringify error, a find-and-replace for all instances of jsonStringify to update the signature to match the changes would probably fix that one

The ptr must be single item pointer error is likely from a side effect of ziglang/zig#16540.

I remember reading a zig PR I think from @mlugg sometime recently that sounded like it'd fix the missing reference traces for comptime function calls so maybe that error message is better in the HEAD build of zig

mlugg · 2023-08-21T09:46:41Z

Yeah, in theory there should be a reference trace now - lemme know if it's still bad

CGQAQ · 2023-08-22T01:51:07Z

There are a lot of comptime related errors after 0.11
ref: https://ziglang.org/download/0.11.0/release-notes.html#Forbid-Runtime-Operations-in-comptime-Blocks-

also the error is very verbose, related to ziglang/zig#12344

A fraction of them

referenced by:
    VerifyJob: src/bun.js/api/bun.zig:1790:54
    VerifyJob: src/bun.js/api/bun.zig:1782:27
    run: src/bun.js/api/bun.zig:1848:44
src/output.zig:221:22: error: unable to resolve comptime value
    std.debug.assert(source_set);
                     ^~~~~~~~~~
src/output.zig:221:22: note: argument to function being called at comptime must be comptime-known
src/report.zig:542:74: note: called from here
                    std.debug.writeStackTrace(trace.*, Output.errorWriter(), default_allocator, debug_info, std.io.tty.detectConfig(std.io.getStdErr())) catch break :print_stacktrace;
                                                       ~~~~~~~~~~~~~~~~~~^~
src/bun.js/api/JSBundler.zig:992:31: error: variable of type '*src.bun.js.api.JSBundler.JSBundler.Resolve' must be const or comptime
                    var this: *JSBundler.Resolve = bun.cast(*Resolve, ctx);
                              ^~~~~~~~~~~~~~~~~~
src/bun.js/api/JSBundler.zig:537:21: note: struct requires comptime because of this field
        completion: ?*bun.BundleV2.JSBundleCompletionTask = null,
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1180:25: note: struct requires comptime because of this field
        jsc_event_loop: *bun.JSC.EventLoop,
                        ^~~~~~~~~~~~~~~~~~
src/bun.js/event_loop.zig:516:22: note: struct requires comptime because of this field
    virtual_machine: *JSC.VirtualMachine = undefined,
                     ^~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:370:14: note: struct requires comptime because of this field
    console: *ZigConsoleClient,
             ^~~~~~~~~~~~~~~~~
src/bun.js/bindings/exports.zig:888:19: note: struct requires comptime because of this field
    error_writer: BufferedWriter,
                  ^~~~~~~~~~~~~~
/snap/zig/8464/lib/std/io/buffered_writer.zig:8:28: note: struct requires comptime because of this field
        unbuffered_writer: WriterType,
                           ^~~~~~~~~~
/snap/zig/8464/lib/std/io/buffered_writer.zig:8:28: note: types are not available at runtime
        unbuffered_writer: WriterType,
                           ^~~~~~~~~~
src/bun.js/bindings/exports.zig:889:13: note: struct requires comptime because of this field
    writer: BufferedWriter,
            ^~~~~~~~~~~~~~
src/bun.js/javascript.zig:379:14: note: struct requires comptime because of this field
    node_fs: ?*Node.NodeFS = null,
             ^~~~~~~~~~~~~
src/bun.js/node/node_fs.zig:3056:9: note: struct requires comptime because of this field
    vm: ?*JSC.VirtualMachine = null,
        ^~~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:426:26: note: struct requires comptime because of this field
    transpiler_store: JSC.RuntimeTranspilerStore,
                      ~~~^~~~~~~~~~~~~~~~~~~~~~~
src/bun.js/module_loader.zig:179:25: note: struct requires comptime because of this field
    store: TranspilerJob.Store,
           ~~~~~~~~~~~~~^~~~~~
src/hive_array.zig:69:28: note: struct requires comptime because of this field
            hive: HiveArray(T, capacity),
                  ~~~~~~~~~^~~~~~~~~~~~~
src/hive_array.zig:12:17: note: struct requires comptime because of this field (11 times)
        buffer: [capacity]T = undefined,
                ^~~~~~~~~~~
src/bun.js/module_loader.zig:221:13: note: struct requires comptime because of this field
        vm: *JSC.VirtualMachine,
            ^~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:445:23: note: struct requires comptime because of this field
    macro_event_loop: EventLoop = EventLoop{},
                      ^~~~~~~~~
src/bun.js/javascript.zig:446:25: note: struct requires comptime because of this field
    regular_event_loop: EventLoop = EventLoop{},
                        ^~~~~~~~~
src/bun.js/javascript.zig:447:17: note: struct requires comptime because of this field
    event_loop: *EventLoop = undefined,
                ^~~~~~~~~~
src/bun.js/javascript.zig:457:16: note: struct requires comptime because of this field
    rare_data: ?*JSC.RareData = null,
               ^~~~~~~~~~~~~~
src/bun.js/rare_data.zig:29:18: note: struct requires comptime because of this field
global_dns_data: ?*JSC.DNS.GlobalData = null,
                 ^~~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1122:15: note: struct requires comptime because of this field
    resolver: DNSResolver,
              ^~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1141:9: note: struct requires comptime because of this field
    vm: *JSC.VirtualMachine,
        ^~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1144:31: note: struct requires comptime because of this field
    pending_host_cache_cares: PendingCache = PendingCache.init(),
                              ^~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:776:17: note: struct requires comptime because of this field
        lookup: *GetAddrInfoRequest = undefined,
                ^~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:721:27: note: struct requires comptime because of this field
    resolver_for_caching: ?*DNSResolver = null,
                          ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1145:32: note: struct requires comptime because of this field
    pending_host_cache_native: PendingCache = PendingCache.init(),
                               ^~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1146:30: note: struct requires comptime because of this field
    pending_srv_cache_cares: SrvPendingCache = SrvPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:673:21: note: struct requires comptime because of this field (9 times)
            lookup: *request_type = undefined,
                    ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:625:31: note: struct requires comptime because of this field (9 times)
        resolver_for_caching: ?*DNSResolver = null,
                              ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1147:30: note: struct requires comptime because of this field
    pending_soa_cache_cares: SoaPendingCache = SoaPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1148:30: note: struct requires comptime because of this field
    pending_txt_cache_cares: TxtPendingCache = TxtPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1149:32: note: struct requires comptime because of this field
    pending_naptr_cache_cares: NaptrPendingCache = NaptrPendingCache.init(),
                               ^~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1150:29: note: struct requires comptime because of this field
    pending_mx_cache_cares: MxPendingCache = MxPendingCache.init(),
                            ^~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1151:30: note: struct requires comptime because of this field
    pending_caa_cache_cares: CaaPendingCache = CaaPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1152:29: note: struct requires comptime because of this field
    pending_ns_cache_cares: NSPendingCache = NSPendingCache.init(),
                            ^~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1153:30: note: struct requires comptime because of this field
    pending_ptr_cache_cares: PtrPendingCache = PtrPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1154:32: note: struct requires comptime because of this field
    pending_cname_cache_cares: CnamePendingCache = CnamePendingCache.init(),
                               ^~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:476:13: note: struct requires comptime because of this field
    worker: ?*JSC.WebWorker = null,
            ^~~~~~~~~~~~~~~
src/bun.js/web_worker.zig:11:9: note: struct requires comptime because of this field
    vm: ?*JSC.VirtualMachine = null,
        ^~~~~~~~~~~~~~~~~~~~
src/bun.js/web_worker.zig:17:13: note: struct requires comptime because of this field
    parent: *JSC.VirtualMachine,
            ^~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1190:15: note: struct requires comptime because of this field
        next: ?*JSBundleCompletionTask = null,
              ^~~~~~~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1191:18: note: struct requires comptime because of this field
        bundler: *BundleV2 = undefined,
                 ^~~~~~~~~
src/bundler/bundle_v2.zig:330:13: note: struct requires comptime because of this field
    linker: LinkerContext = LinkerContext{ .loop = undefined },
            ^~~~~~~~~~~~~
src/bundler/bundle_v2.zig:3533:11: note: struct requires comptime because of this field
    loop: EventLoop,
          ^~~~~~~~~
src/bun.js/event_loop.zig:995:10: note: union requires comptime because of this field
    jsc: *EventLoop,
         ^~~~~~~~~~
src/bundler/bundle_v2.zig:331:18: note: struct requires comptime because of this field
    bun_watcher: ?*Watcher.Watcher = null,
                 ^~~~~~~~~~~~~~~~~
src/watcher.zig:367:14: note: struct requires comptime because of this field
        ctx: ContextType,
             ^~~~~~~~~~~
src/bun.js/javascript.zig:2648:14: note: struct requires comptime because of this field
        ctx: *Ctx,
             ^~~~
src/bundler/bundle_v2.zig:333:17: note: struct requires comptime because of this field
    completion: ?*JSBundleCompletionTask = null,
                ^~~~~~~~~~~~~~~~~~~~~~~~
src/bun.js/bindings/exports.zig:2264:30: error: unable to resolve comptime value
                    if (value.as(JSC.WebCore.Response)) |response| {
                        ~~~~~^~~
src/bun.js/bindings/exports.zig:2264:30: note: argument to function being called at comptime must be comptime-known
src/bun.js/bindings/bindings.zig:3544:55: note: expression is evaluated at comptime because the generic function was instantiated with a comptime-only return type
    pub fn as(value: JSValue, comptime ZigType: type) ?*ZigType {
                                                      ^~~~~~~~~
referenced by:
    format__anon_135757: src/bun.js/bindings/exports.zig:3058:41
    printAs__anon_178061: src/bun.js/bindings/exports.zig:2241:40
src/bun.js/bindings/exports.zig:2264:30: error: unable to resolve comptime value
                    if (value.as(JSC.WebCore.Response)) |response| {
                        ~~~~~^~~
src/bun.js/bindings/exports.zig:2264:30: note: argument to function being called at comptime must be comptime-known
src/bun.js/bindings/bindings.zig:3544:55: note: expression is evaluated at comptime because the generic function was instantiated with a comptime-only return type
    pub fn as(value: JSValue, comptime ZigType: type) ?*ZigType {
                                                      ^~~~~~~~~
referenced by:
    format__anon_135758: src/bun.js/bindings/exports.zig:3058:41
    printAs__anon_178088: src/bun.js/bindings/exports.zig:2241:40
src/bun.js/api/JSBundler.zig:671:13: error: parameter of type '*src.bun.js.api.JSBundler.JSBundler.Resolve' not allowed in function with calling convention 'C'
            this: *Resolve,
            ^~~~~~~~~~~~~~
src/bun.js/api/JSBundler.zig:671:13: note: pointer to comptime-only type 'src.bun.js.api.JSBundler.JSBundler.Resolve'
src/bun.js/api/JSBundler.zig:537:21: note: struct requires comptime because of this field
        completion: ?*bun.BundleV2.JSBundleCompletionTask = null,
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1180:25: note: struct requires comptime because of this field
        jsc_event_loop: *bun.JSC.EventLoop,
                        ^~~~~~~~~~~~~~~~~~
src/bun.js/event_loop.zig:516:22: note: struct requires comptime because of this field
    virtual_machine: *JSC.VirtualMachine = undefined,
                     ^~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:370:14: note: struct requires comptime because of this field
    console: *ZigConsoleClient,
             ^~~~~~~~~~~~~~~~~
src/bun.js/bindings/exports.zig:888:19: note: struct requires comptime because of this field
    error_writer: BufferedWriter,
                  ^~~~~~~~~~~~~~
/snap/zig/8464/lib/std/io/buffered_writer.zig:8:28: note: struct requires comptime because of this field
        unbuffered_writer: WriterType,
                           ^~~~~~~~~~
/snap/zig/8464/lib/std/io/buffered_writer.zig:8:28: note: types are not available at runtime
        unbuffered_writer: WriterType,
                           ^~~~~~~~~~
src/bun.js/bindings/exports.zig:889:13: note: struct requires comptime because of this field
    writer: BufferedWriter,
            ^~~~~~~~~~~~~~
src/bun.js/javascript.zig:379:14: note: struct requires comptime because of this field
    node_fs: ?*Node.NodeFS = null,
             ^~~~~~~~~~~~~
src/bun.js/node/node_fs.zig:3056:9: note: struct requires comptime because of this field
    vm: ?*JSC.VirtualMachine = null,
        ^~~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:426:26: note: struct requires comptime because of this field
    transpiler_store: JSC.RuntimeTranspilerStore,
                      ~~~^~~~~~~~~~~~~~~~~~~~~~~
src/bun.js/module_loader.zig:179:25: note: struct requires comptime because of this field
    store: TranspilerJob.Store,
           ~~~~~~~~~~~~~^~~~~~
src/hive_array.zig:69:28: note: struct requires comptime because of this field
            hive: HiveArray(T, capacity),
                  ~~~~~~~~~^~~~~~~~~~~~~
src/hive_array.zig:12:17: note: struct requires comptime because of this field (11 times)
        buffer: [capacity]T = undefined,
                ^~~~~~~~~~~
src/bun.js/module_loader.zig:221:13: note: struct requires comptime because of this field
        vm: *JSC.VirtualMachine,
            ^~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:445:23: note: struct requires comptime because of this field
    macro_event_loop: EventLoop = EventLoop{},
                      ^~~~~~~~~
src/bun.js/javascript.zig:446:25: note: struct requires comptime because of this field
    regular_event_loop: EventLoop = EventLoop{},
                        ^~~~~~~~~
src/bun.js/javascript.zig:447:17: note: struct requires comptime because of this field
    event_loop: *EventLoop = undefined,
                ^~~~~~~~~~
src/bun.js/javascript.zig:457:16: note: struct requires comptime because of this field
    rare_data: ?*JSC.RareData = null,
               ^~~~~~~~~~~~~~
src/bun.js/rare_data.zig:29:18: note: struct requires comptime because of this field
global_dns_data: ?*JSC.DNS.GlobalData = null,
                 ^~~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1122:15: note: struct requires comptime because of this field
    resolver: DNSResolver,
              ^~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1141:9: note: struct requires comptime because of this field
    vm: *JSC.VirtualMachine,
        ^~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1144:31: note: struct requires comptime because of this field
    pending_host_cache_cares: PendingCache = PendingCache.init(),
                              ^~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:776:17: note: struct requires comptime because of this field
        lookup: *GetAddrInfoRequest = undefined,
                ^~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:721:27: note: struct requires comptime because of this field
    resolver_for_caching: ?*DNSResolver = null,
                          ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1145:32: note: struct requires comptime because of this field
    pending_host_cache_native: PendingCache = PendingCache.init(),
                               ^~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1146:30: note: struct requires comptime because of this field
    pending_srv_cache_cares: SrvPendingCache = SrvPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:673:21: note: struct requires comptime because of this field (9 times)
            lookup: *request_type = undefined,
                    ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:625:31: note: struct requires comptime because of this field (9 times)
        resolver_for_caching: ?*DNSResolver = null,
                              ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1147:30: note: struct requires comptime because of this field
    pending_soa_cache_cares: SoaPendingCache = SoaPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1148:30: note: struct requires comptime because of this field
    pending_txt_cache_cares: TxtPendingCache = TxtPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1149:32: note: struct requires comptime because of this field
    pending_naptr_cache_cares: NaptrPendingCache = NaptrPendingCache.init(),
                               ^~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1150:29: note: struct requires comptime because of this field
    pending_mx_cache_cares: MxPendingCache = MxPendingCache.init(),
                            ^~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1151:30: note: struct requires comptime because of this field
    pending_caa_cache_cares: CaaPendingCache = CaaPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1152:29: note: struct requires comptime because of this field
    pending_ns_cache_cares: NSPendingCache = NSPendingCache.init(),
                            ^~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1153:30: note: struct requires comptime because of this field
    pending_ptr_cache_cares: PtrPendingCache = PtrPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1154:32: note: struct requires comptime because of this field
    pending_cname_cache_cares: CnamePendingCache = CnamePendingCache.init(),
                               ^~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:476:13: note: struct requires comptime because of this field
    worker: ?*JSC.WebWorker = null,
            ^~~~~~~~~~~~~~~
src/bun.js/web_worker.zig:11:9: note: struct requires comptime because of this field
    vm: ?*JSC.VirtualMachine = null,
        ^~~~~~~~~~~~~~~~~~~~
src/bun.js/web_worker.zig:17:13: note: struct requires comptime because of this field
    parent: *JSC.VirtualMachine,
            ^~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1190:15: note: struct requires comptime because of this field
        next: ?*JSBundleCompletionTask = null,
              ^~~~~~~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1191:18: note: struct requires comptime because of this field
        bundler: *BundleV2 = undefined,
                 ^~~~~~~~~
src/bundler/bundle_v2.zig:330:13: note: struct requires comptime because of this field
    linker: LinkerContext = LinkerContext{ .loop = undefined },
            ^~~~~~~~~~~~~
src/bundler/bundle_v2.zig:3533:11: note: struct requires comptime because of this field
    loop: EventLoop,
          ^~~~~~~~~
src/bun.js/event_loop.zig:995:10: note: union requires comptime because of this field
    jsc: *EventLoop,
         ^~~~~~~~~~
src/bundler/bundle_v2.zig:331:18: note: struct requires comptime because of this field
    bun_watcher: ?*Watcher.Watcher = null,
                 ^~~~~~~~~~~~~~~~~
src/watcher.zig:367:14: note: struct requires comptime because of this field
        ctx: ContextType,
             ^~~~~~~~~~~
src/bun.js/javascript.zig:2648:14: note: struct requires comptime because of this field
        ctx: *Ctx,
             ^~~~
src/bundler/bundle_v2.zig:333:17: note: struct requires comptime because of this field
    completion: ?*JSBundleCompletionTask = null,
                ^~~~~~~~~~~~~~~~~~~~~~~~
/snap/zig/8464/lib/std/multi_array_list.zig:560:26: error: extern structs cannot contain fields of type '*src.baby_list.BabyList(src.bun.js.javascript.NewHotReloader(src.bundler.bundle_v2.BundleV2,src.bun.js.event_loop.AnyEventLoop,true).NewCallback(fn(comptime *src.bun.js.javascript.VirtualMachine, []const u8) void))'
            break :entry @Type(.{ .Struct = .{
                         ^~~~~
/snap/zig/8464/lib/std/multi_array_list.zig:560:26: note: pointer to comptime-only type 'src.baby_list.BabyList(src.bun.js.javascript.NewHotReloader(src.bundler.bundle_v2.BundleV2,src.bun.js.event_loop.AnyEventLoop,true).NewCallback(fn(comptime *src.bun.js.javascript.VirtualMachine, []const u8) void))'
src/baby_list.zig:11:15: note: struct requires comptime because of this field
        ptr: [*]Type = undefined,
             ~^~~~~~
src/bun.js/javascript.zig:2713:31: note: union requires comptime because of this field
                zig_callback: struct {
                              ^~~~~~
src/bun.js/javascript.zig:2715:31: note: struct requires comptime because of this field
                    function: *const FunctionSignature,
                              ^~~~~~~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:2715:31: note: function is generic
                    function: *const FunctionSignature,
                              ^~~~~~~~~~~~~~~~~~~~~~~~
referenced by:
    dbHelper: /snap/zig/8464/lib/std/multi_array_list.zig:569:71
    comptime_0: /snap/zig/8464/lib/std/multi_array_list.zig:578:22
/snap/zig/8464/lib/std/multi_array_list.zig:560:26: error: extern structs cannot contain fields of type '**src.bundler.bundle_v2.ThreadPool.Worker'
            break :entry @Type(.{ .Struct = .{
                         ^~~~~
/snap/zig/8464/lib/std/multi_array_list.zig:560:26: note: pointer to comptime-only type '*src.bundler.bundle_v2.ThreadPool.Worker'
src/bundler/bundle_v2.zig:208:14: note: struct requires comptime because of this field
        ctx: *BundleV2,
             ^~~~~~~~~
src/bundler/bundle_v2.zig:330:13: note: struct requires comptime because of this field
    linker: LinkerContext = LinkerContext{ .loop = undefined },
            ^~~~~~~~~~~~~
src/bundler/bundle_v2.zig:3533:11: note: struct requires comptime because of this field
    loop: EventLoop,
          ^~~~~~~~~
src/bun.js/event_loop.zig:995:10: note: union requires comptime because of this field
    jsc: *EventLoop,
         ^~~~~~~~~~
src/bun.js/event_loop.zig:516:22: note: struct requires comptime because of this field
    virtual_machine: *JSC.VirtualMachine = undefined,
                     ^~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:370:14: note: struct requires comptime because of this field
    console: *ZigConsoleClient,
             ^~~~~~~~~~~~~~~~~
src/bun.js/bindings/exports.zig:888:19: note: struct requires comptime because of this field
    error_writer: BufferedWriter,
                  ^~~~~~~~~~~~~~
/snap/zig/8464/lib/std/io/buffered_writer.zig:8:28: note: struct requires comptime because of this field
        unbuffered_writer: WriterType,
                           ^~~~~~~~~~
/snap/zig/8464/lib/std/io/buffered_writer.zig:8:28: note: types are not available at runtime
        unbuffered_writer: WriterType,
                           ^~~~~~~~~~
src/bun.js/bindings/exports.zig:889:13: note: struct requires comptime because of this field
    writer: BufferedWriter,
            ^~~~~~~~~~~~~~
src/bun.js/javascript.zig:379:14: note: struct requires comptime because of this field
    node_fs: ?*Node.NodeFS = null,
             ^~~~~~~~~~~~~
src/bun.js/node/node_fs.zig:3056:9: note: struct requires comptime because of this field
    vm: ?*JSC.VirtualMachine = null,
        ^~~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:426:26: note: struct requires comptime because of this field
    transpiler_store: JSC.RuntimeTranspilerStore,
                      ~~~^~~~~~~~~~~~~~~~~~~~~~~
src/bun.js/module_loader.zig:179:25: note: struct requires comptime because of this field
    store: TranspilerJob.Store,
           ~~~~~~~~~~~~~^~~~~~
src/hive_array.zig:69:28: note: struct requires comptime because of this field
            hive: HiveArray(T, capacity),
                  ~~~~~~~~~^~~~~~~~~~~~~
src/hive_array.zig:12:17: note: struct requires comptime because of this field (11 times)
        buffer: [capacity]T = undefined,
                ^~~~~~~~~~~
src/bun.js/module_loader.zig:221:13: note: struct requires comptime because of this field
        vm: *JSC.VirtualMachine,
            ^~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:445:23: note: struct requires comptime because of this field
    macro_event_loop: EventLoop = EventLoop{},
                      ^~~~~~~~~
src/bun.js/javascript.zig:446:25: note: struct requires comptime because of this field
    regular_event_loop: EventLoop = EventLoop{},
                        ^~~~~~~~~
src/bun.js/javascript.zig:447:17: note: struct requires comptime because of this field
    event_loop: *EventLoop = undefined,
                ^~~~~~~~~~
src/bun.js/javascript.zig:457:16: note: struct requires comptime because of this field
    rare_data: ?*JSC.RareData = null,
               ^~~~~~~~~~~~~~
src/bun.js/rare_data.zig:29:18: note: struct requires comptime because of this field
global_dns_data: ?*JSC.DNS.GlobalData = null,
                 ^~~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1122:15: note: struct requires comptime because of this field
    resolver: DNSResolver,
              ^~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1141:9: note: struct requires comptime because of this field
    vm: *JSC.VirtualMachine,
        ^~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1144:31: note: struct requires comptime because of this field
    pending_host_cache_cares: PendingCache = PendingCache.init(),
                              ^~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:776:17: note: struct requires comptime because of this field
        lookup: *GetAddrInfoRequest = undefined,
                ^~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:721:27: note: struct requires comptime because of this field
    resolver_for_caching: ?*DNSResolver = null,
                          ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1145:32: note: struct requires comptime because of this field
    pending_host_cache_native: PendingCache = PendingCache.init(),
                               ^~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1146:30: note: struct requires comptime because of this field
    pending_srv_cache_cares: SrvPendingCache = SrvPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:673:21: note: struct requires comptime because of this field (9 times)
            lookup: *request_type = undefined,
                    ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:625:31: note: struct requires comptime because of this field (9 times)
        resolver_for_caching: ?*DNSResolver = null,
                              ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1147:30: note: struct requires comptime because of this field
    pending_soa_cache_cares: SoaPendingCache = SoaPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1148:30: note: struct requires comptime because of this field
    pending_txt_cache_cares: TxtPendingCache = TxtPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1149:32: note: struct requires comptime because of this field
    pending_naptr_cache_cares: NaptrPendingCache = NaptrPendingCache.init(),
                               ^~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1150:29: note: struct requires comptime because of this field
    pending_mx_cache_cares: MxPendingCache = MxPendingCache.init(),
                            ^~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1151:30: note: struct requires comptime because of this field
    pending_caa_cache_cares: CaaPendingCache = CaaPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1152:29: note: struct requires comptime because of this field
    pending_ns_cache_cares: NSPendingCache = NSPendingCache.init(),
                            ^~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1153:30: note: struct requires comptime because of this field
    pending_ptr_cache_cares: PtrPendingCache = PtrPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1154:32: note: struct requires comptime because of this field
    pending_cname_cache_cares: CnamePendingCache = CnamePendingCache.init(),
                               ^~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:476:13: note: struct requires comptime because of this field
    worker: ?*JSC.WebWorker = null,
            ^~~~~~~~~~~~~~~
src/bun.js/web_worker.zig:11:9: note: struct requires comptime because of this field
    vm: ?*JSC.VirtualMachine = null,
        ^~~~~~~~~~~~~~~~~~~~
src/bun.js/web_worker.zig:17:13: note: struct requires comptime because of this field
    parent: *JSC.VirtualMachine,
            ^~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:331:18: note: struct requires comptime because of this field
    bun_watcher: ?*Watcher.Watcher = null,
                 ^~~~~~~~~~~~~~~~~
src/watcher.zig:367:14: note: struct requires comptime because of this field
        ctx: ContextType,
             ^~~~~~~~~~~
src/bun.js/javascript.zig:2648:14: note: struct requires comptime because of this field
        ctx: *Ctx,
             ^~~~
src/bundler/bundle_v2.zig:333:17: note: struct requires comptime because of this field
    completion: ?*JSBundleCompletionTask = null,
                ^~~~~~~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1180:25: note: struct requires comptime because of this field
        jsc_event_loop: *bun.JSC.EventLoop,
                        ^~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1190:15: note: struct requires comptime because of this field
        next: ?*JSBundleCompletionTask = null,
              ^~~~~~~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1191:18: note: struct requires comptime because of this field
        bundler: *BundleV2 = undefined,
                 ^~~~~~~~~
referenced by:
    dbHelper: /snap/zig/8464/lib/std/multi_array_list.zig:569:71
    comptime_0: /snap/zig/8464/lib/std/multi_array_list.zig:578:22
src/bundler/bundle_v2.zig:234:23: error: parameter of type '*src.bundler.bundle_v2.ThreadPool.Worker' must be declared comptime
        pub fn deinit(this: *Worker) void {
                      ^~~~~~~~~~~~~
src/bundler/bundle_v2.zig:208:14: note: struct requires comptime because of this field
        ctx: *BundleV2,
             ^~~~~~~~~
src/bundler/bundle_v2.zig:330:13: note: struct requires comptime because of this field
    linker: LinkerContext = LinkerContext{ .loop = undefined },
            ^~~~~~~~~~~~~
src/bundler/bundle_v2.zig:3533:11: note: struct requires comptime because of this field
    loop: EventLoop,
          ^~~~~~~~~
src/bun.js/event_loop.zig:995:10: note: union requires comptime because of this field
    jsc: *EventLoop,
         ^~~~~~~~~~
src/bun.js/event_loop.zig:516:22: note: struct requires comptime because of this field
    virtual_machine: *JSC.VirtualMachine = undefined,
                     ^~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:370:14: note: struct requires comptime because of this field
    console: *ZigConsoleClient,
             ^~~~~~~~~~~~~~~~~
src/bun.js/bindings/exports.zig:888:19: note: struct requires comptime because of this field
    error_writer: BufferedWriter,
                  ^~~~~~~~~~~~~~
/snap/zig/8464/lib/std/io/buffered_writer.zig:8:28: note: struct requires comptime because of this field
        unbuffered_writer: WriterType,
                           ^~~~~~~~~~
/snap/zig/8464/lib/std/io/buffered_writer.zig:8:28: note: types are not available at runtime
        unbuffered_writer: WriterType,
                           ^~~~~~~~~~
src/bun.js/bindings/exports.zig:889:13: note: struct requires comptime because of this field
    writer: BufferedWriter,
            ^~~~~~~~~~~~~~
src/bun.js/javascript.zig:379:14: note: struct requires comptime because of this field
    node_fs: ?*Node.NodeFS = null,
             ^~~~~~~~~~~~~
src/bun.js/node/node_fs.zig:3056:9: note: struct requires comptime because of this field
    vm: ?*JSC.VirtualMachine = null,
        ^~~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:426:26: note: struct requires comptime because of this field
    transpiler_store: JSC.RuntimeTranspilerStore,
                      ~~~^~~~~~~~~~~~~~~~~~~~~~~
src/bun.js/module_loader.zig:179:25: note: struct requires comptime because of this field
    store: TranspilerJob.Store,
           ~~~~~~~~~~~~~^~~~~~
src/hive_array.zig:69:28: note: struct requires comptime because of this field
            hive: HiveArray(T, capacity),
                  ~~~~~~~~~^~~~~~~~~~~~~
src/hive_array.zig:12:17: note: struct requires comptime because of this field (11 times)
        buffer: [capacity]T = undefined,
                ^~~~~~~~~~~
src/bun.js/module_loader.zig:221:13: note: struct requires comptime because of this field
        vm: *JSC.VirtualMachine,
            ^~~~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:445:23: note: struct requires comptime because of this field
    macro_event_loop: EventLoop = EventLoop{},
                      ^~~~~~~~~
src/bun.js/javascript.zig:446:25: note: struct requires comptime because of this field
    regular_event_loop: EventLoop = EventLoop{},
                        ^~~~~~~~~
src/bun.js/javascript.zig:447:17: note: struct requires comptime because of this field
    event_loop: *EventLoop = undefined,
                ^~~~~~~~~~
src/bun.js/javascript.zig:457:16: note: struct requires comptime because of this field
    rare_data: ?*JSC.RareData = null,
               ^~~~~~~~~~~~~~
src/bun.js/rare_data.zig:29:18: note: struct requires comptime because of this field
global_dns_data: ?*JSC.DNS.GlobalData = null,
                 ^~~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1122:15: note: struct requires comptime because of this field
    resolver: DNSResolver,
              ^~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1141:9: note: struct requires comptime because of this field
    vm: *JSC.VirtualMachine,
        ^~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1144:31: note: struct requires comptime because of this field
    pending_host_cache_cares: PendingCache = PendingCache.init(),
                              ^~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:776:17: note: struct requires comptime because of this field
        lookup: *GetAddrInfoRequest = undefined,
                ^~~~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:721:27: note: struct requires comptime because of this field
    resolver_for_caching: ?*DNSResolver = null,
                          ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1145:32: note: struct requires comptime because of this field
    pending_host_cache_native: PendingCache = PendingCache.init(),
                               ^~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1146:30: note: struct requires comptime because of this field
    pending_srv_cache_cares: SrvPendingCache = SrvPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:673:21: note: struct requires comptime because of this field (9 times)
            lookup: *request_type = undefined,
                    ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:625:31: note: struct requires comptime because of this field (9 times)
        resolver_for_caching: ?*DNSResolver = null,
                              ^~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1147:30: note: struct requires comptime because of this field
    pending_soa_cache_cares: SoaPendingCache = SoaPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1148:30: note: struct requires comptime because of this field
    pending_txt_cache_cares: TxtPendingCache = TxtPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1149:32: note: struct requires comptime because of this field
    pending_naptr_cache_cares: NaptrPendingCache = NaptrPendingCache.init(),
                               ^~~~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1150:29: note: struct requires comptime because of this field
    pending_mx_cache_cares: MxPendingCache = MxPendingCache.init(),
                            ^~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1151:30: note: struct requires comptime because of this field
    pending_caa_cache_cares: CaaPendingCache = CaaPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1152:29: note: struct requires comptime because of this field
    pending_ns_cache_cares: NSPendingCache = NSPendingCache.init(),
                            ^~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1153:30: note: struct requires comptime because of this field
    pending_ptr_cache_cares: PtrPendingCache = PtrPendingCache.init(),
                             ^~~~~~~~~~~~~~~
src/bun.js/api/bun/dns_resolver.zig:1154:32: note: struct requires comptime because of this field
    pending_cname_cache_cares: CnamePendingCache = CnamePendingCache.init(),
                               ^~~~~~~~~~~~~~~~~
src/bun.js/javascript.zig:476:13: note: struct requires comptime because of this field
    worker: ?*JSC.WebWorker = null,
            ^~~~~~~~~~~~~~~
src/bun.js/web_worker.zig:11:9: note: struct requires comptime because of this field
    vm: ?*JSC.VirtualMachine = null,
        ^~~~~~~~~~~~~~~~~~~~
src/bun.js/web_worker.zig:17:13: note: struct requires comptime because of this field
    parent: *JSC.VirtualMachine,
            ^~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:331:18: note: struct requires comptime because of this field
    bun_watcher: ?*Watcher.Watcher = null,
                 ^~~~~~~~~~~~~~~~~
src/watcher.zig:367:14: note: struct requires comptime because of this field
        ctx: ContextType,
             ^~~~~~~~~~~
src/bun.js/javascript.zig:2648:14: note: struct requires comptime because of this field
        ctx: *Ctx,
             ^~~~
src/bundler/bundle_v2.zig:333:17: note: struct requires comptime because of this field
    completion: ?*JSBundleCompletionTask = null,
                ^~~~~~~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1180:25: note: struct requires comptime because of this field
        jsc_event_loop: *bun.JSC.EventLoop,
                        ^~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1190:15: note: struct requires comptime because of this field
        next: ?*JSBundleCompletionTask = null,
              ^~~~~~~~~~~~~~~~~~~~~~~~
src/bundler/bundle_v2.zig:1191:18: note: struct requires comptime because of this field
        bundler: *BundleV2 = undefined,
                 ^~~~~~~~~
referenced by:
    deinitCallback: src/bundler/bundle_v2.zig:225:17
    Worker: src/bundler/bundle_v2.zig:217:58
    Worker: src/bundler/bundle_v2.zig:201:24
    deinit: src/bundler/bundle_v2.zig:234:30
src/bundler/bundle_v2.zig:3585:54: error: unable to evaluate comptime expression
                SourceMapData.computeLineOffsets(task.ctx, ThreadPool.Worker.get(@fieldParentPtr(BundleV2, "linker", task.ctx)).allocator, task.source_index);
                                                 ~~~~^~~~
referenced by:
    Task: src/bundler/bundle_v2.zig:3576:63
    Task: src/bundler/bundle_v2.zig:3573:26
    runLineOffset: src/bundler/bundle_v2.zig:3579:44

Jarred-Sumner · 2023-08-22T02:03:30Z

This sounds like a zig bug. None of those should need to be comptime

CGQAQ · 2023-08-22T02:14:10Z

Not sure, I'll file an issue in the Zig repo

ianprime0509 · 2023-08-22T05:07:28Z

At least some of these appear to be due to this change: https://github.com/oven-sh/bun/pull/4233/files#diff-f2619d0e89ac22f8e6016642173178fea360dd0ea1bddf72f1b9ea078e1db9c9R218

The line in question in case the link above dies:

pub const WriterType: type = @TypeOf(WriteStream(Source.StreamType, undefined));

WriteStream is already a type, so the result of the @TypeOf is type, which is not the intended value of WriterType. I believe what was intended is

pub const WriterType: type = WriteStream(Source.StreamType, undefined);

CGQAQ · 2023-08-22T07:33:55Z

@mlugg These errors in 0.12.0-dev.157+8e96be008 still not helpful

Details

zig build-obj bun-debug Debug native-native-gnu.2.27: error: the following command failed with 2 compilation errors:
/snap/zig/8471/zig build-obj -freference-trace=256 /root/repos/bun/root.zig -lc -fno-emit-bin -fno-strip --eh-frame-hdr --emit-relocs -ffunction-sections --cache-dir /root/repos/bun/zig-cache --global-cache-dir /root/.cache/zig --name bun-debug -fno-compiler-rt -fno-stack-check -fno-omit-frame-pointer -target native-native-gnu.2.27 -mcpu haswell --mod build_options::/root/repos/bun/zig-cache/c/f4c3edf58352d0a7649af44b7b307bb6/options.zig --mod async_io::/root/repos/bun/src/io/io_linux.zig --deps async_io,build_options --main-pkg-path /root/repos/bun --listen=- 
Build Summary: 1/4 steps succeeded; 1 failed (disable with --summary none)
install transitive failure
└─ obj transitive failure
   └─ zig build-obj bun-debug Debug native-native-gnu.2.27 2 errors
/snap/zig/8471/lib/std/mem.zig:4143:9: error: expected []T or *[_]T, passed [*:0]const u8
        @compileError("expected []T or *[_]T, passed " ++ @typeName(Slice));
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/snap/zig/8471/lib/std/mem.zig:4150:59: note: called from here
pub fn sliceAsBytes(slice: anytype) SliceAsBytesReturnType(@TypeOf(slice)) {
                                    ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
/snap/zig/8471/lib/std/mem.zig:4143:9: error: expected []T or *[_]T, passed [*]u8
        @compileError("expected []T or *[_]T, passed " ++ @typeName(Slice));
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/snap/zig/8471/lib/std/mem.zig:4150:59: note: called from here
pub fn sliceAsBytes(slice: anytype) SliceAsBytesReturnType(@TypeOf(slice)) {

UPDATE:
~~still have an error (the other one was found by search @as([*]const u8, compiler error was not helpful)~~

/snap/zig/8471/lib/std/mem.zig:4143:9: error: expected []T or *[_]T, passed [*:0]const u8
        @compileError("expected []T or *[_]T, passed " ++ @typeName(Slice));
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

~~I cannot found any [*:0]const u8 is been passed into free as of now~~

mlugg · 2023-08-22T07:36:53Z

Will try and take a look when I'm briefly at home

src/bun.js/api/server.zig

Hanaasagi · 2023-08-22T13:47:45Z

It may be helpful to you.

CGQAQ · 2023-08-23T01:48:18Z

Debug build

Release build

CGQAQ · 2023-08-23T02:42:11Z

@Jarred-Sumner I think it's ready for review

dylan-conway · 2023-08-23T05:00:19Z

Can you search and update 0.11.0-dev.4006+bf827d0b5 to the new version you have compiling? After that it looks good to me.

CGQAQ · 2023-08-23T05:23:59Z

@dylan-conway replaced

dylan-conway · 2023-08-23T07:12:11Z

@CGQAQ it's fs_events.zig line 491

CGQAQ · 2023-08-23T07:14:23Z

@CGQAQ it's fs_events.zig line 491

Oh, thanks, changed

CGQAQ · 2023-08-23T09:02:45Z

These failing tests are expected, right? @Jarred-Sumner

CGQAQ · 2023-08-24T09:12:07Z

@Jarred-Sumner @dylan-conway Is there anything else I should change before this could land?

dylan-conway · 2023-08-24T23:12:34Z

@CGQAQ Some test failures in CI are expected right now. I took a look and nothing is out of the ordinary. Thanks for working on this!

CGQAQ added 2 commits August 21, 2023 08:48

WIP

6d3d7b1

Merge branch 'main' into zig-0.11.0

7f35d92

CGQAQ added 2 commits August 21, 2023 09:51

backup

14d6439

more change

fbe5182

This comment was marked as resolved.

Sign in to view

json related error sovled

7de2890

CGQAQ mentioned this pull request Aug 22, 2023

Got a lot of comptime related errors after update to zig 0.11 ziglang/zig#16920

Closed

CGQAQ added 2 commits August 22, 2023 07:36

number related issue solved

3be5af9

revert WriterType changed before

550c697

CGQAQ added 3 commits August 22, 2023 07:37

destroy -> free

f76919e

jsonStringify related issues solved

4a9251e

fix mem.free expected []T or *[_]T, passed [*]const u8

9ac48ac

Hanaasagi reviewed Aug 22, 2023

View reviewed changes

src/bun.js/api/server.zig Outdated Show resolved Hide resolved

fix expected []T or *[_]T, passed [*:0]const u8

25b14b7

This comment was marked as resolved.

Sign in to view

fix build script

e8e628f

fix build script, for real

147368d

CGQAQ marked this pull request as ready for review August 23, 2023 02:41

Merge branch 'main' into zig-0.11.0

88abe3c

CGQAQ added 2 commits August 23, 2023 05:22

replace 0.11.0-dev.4006+bf827d0b5 to 0.12.0-dev.161+6a5463951

1779f89

Merge branch 'main' into zig-0.11.0

7246938

fix build on macOS, COPYFILE.DATA -> COPYFILE_DATA

edae96f

This comment was marked as resolved.

Sign in to view

fix the last destroy on [*]ptr issue

fce7c89

CGQAQ force-pushed the zig-0.11.0 branch from 806cac1 to fce7c89 Compare August 23, 2023 07:15

Merge branch 'main' into zig-0.11.0

ca72dbb

dylan-conway approved these changes Aug 24, 2023

View reviewed changes

dylan-conway merged commit 19aa9d9 into oven-sh:main Aug 24, 2023
12 checks passed

CGQAQ deleted the zig-0.11.0 branch August 25, 2023 00:39

birkskyum mentioned this pull request Aug 26, 2023

Zig fork doesn't work on macOS Ventura #1490

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update zig to 0.11.0 #4233

update zig to 0.11.0 #4233

CGQAQ commented Aug 21, 2023 •

edited

Loading

Jarred-Sumner commented Aug 21, 2023

mlugg commented Aug 21, 2023

This comment was marked as resolved.

CGQAQ commented Aug 22, 2023 •

edited

Loading

Jarred-Sumner commented Aug 22, 2023

CGQAQ commented Aug 22, 2023

ianprime0509 commented Aug 22, 2023

CGQAQ commented Aug 22, 2023 •

edited

Loading

mlugg commented Aug 22, 2023

This comment was marked as resolved.

Hanaasagi commented Aug 22, 2023

CGQAQ commented Aug 23, 2023 •

edited

Loading

CGQAQ commented Aug 23, 2023

dylan-conway commented Aug 23, 2023

CGQAQ commented Aug 23, 2023

This comment was marked as resolved.

dylan-conway commented Aug 23, 2023

CGQAQ commented Aug 23, 2023

CGQAQ commented Aug 23, 2023 •

edited

Loading

CGQAQ commented Aug 24, 2023

dylan-conway commented Aug 24, 2023

update zig to 0.11.0 #4233

update zig to 0.11.0 #4233

Conversation

CGQAQ commented Aug 21, 2023 • edited Loading

What does this PR do?

How did you verify your code works?

Jarred-Sumner commented Aug 21, 2023

mlugg commented Aug 21, 2023

This comment was marked as resolved.

CGQAQ commented Aug 22, 2023 • edited Loading

Jarred-Sumner commented Aug 22, 2023

CGQAQ commented Aug 22, 2023

ianprime0509 commented Aug 22, 2023

CGQAQ commented Aug 22, 2023 • edited Loading

mlugg commented Aug 22, 2023

This comment was marked as resolved.

Hanaasagi commented Aug 22, 2023

CGQAQ commented Aug 23, 2023 • edited Loading

CGQAQ commented Aug 23, 2023

dylan-conway commented Aug 23, 2023

CGQAQ commented Aug 23, 2023

This comment was marked as resolved.

dylan-conway commented Aug 23, 2023

CGQAQ commented Aug 23, 2023

CGQAQ commented Aug 23, 2023 • edited Loading

CGQAQ commented Aug 24, 2023

dylan-conway commented Aug 24, 2023

CGQAQ commented Aug 21, 2023 •

edited

Loading

CGQAQ commented Aug 22, 2023 •

edited

Loading

CGQAQ commented Aug 22, 2023 •

edited

Loading

CGQAQ commented Aug 23, 2023 •

edited

Loading

CGQAQ commented Aug 23, 2023 •

edited

Loading