Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix; Annotations 'ThriftBundle:Thrift:server' no longer work for S… #35

Merged
merged 2 commits into from
Aug 3, 2018

Conversation

farazive
Copy link
Contributor

@farazive farazive commented Aug 3, 2018

bugfix; Annotations 'ThriftBundle:Thrift:server' no longer work for Symfony 4 when passing '_controller'. Passing 'Overblog\ThriftBundle\Controller\ThriftController::serverAction' instead

…ymfony 4 when passing '_controller'. Passing 'Overblog\ThriftBundle\Controller\ThriftController::serverAction' instead
Copy link
Member

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Some minor change and we can merge this

@@ -11,6 +11,7 @@

namespace Overblog\ThriftBundle\Routing;

use App\Kernel;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong class replace by Symfony\Component\HttpKernel\Kernel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing it right now.. thanks

Copy link
Member

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcg-web mcg-web merged commit ab1739d into overblog:0.9 Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants