Remove wrapping quotes from env settings #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
approved these changes
Jul 11, 2022
arbrandes
approved these changes
Jul 11, 2022
5 tasks
ghassanmas
added a commit
to ghassanmas/tutor-mfe
that referenced
this pull request
Sep 13, 2022
tutor-mfe set SITE_NAME env variable of mfe to equal PLATFORM_NAME config value, however in case it has a space, this would result SITE_NAME to be empty. This change prefix space with \ as, i.e My Site becaomse My\ Site. Before this might not has been issued because all values were wrapped with ' hence overhangio#56 To test this change (you have to be in production mode) - Set your PLATFORM_NAME to any thing that incldues space - Build the mfe image - Check `document.title` in dev console of any mfe - It will not incldue PLATFORM_NAME After applying this patch, the last step above, should result the PLATFORM_NAME i.e. "Learning | PLATFORM_NAME"
regisb
pushed a commit
that referenced
this pull request
Oct 3, 2022
tutor-mfe set SITE_NAME env variable of mfe to equal PLATFORM_NAME config value, however in case it has a space, this would result SITE_NAME to be empty. This change prefix space with \ as, i.e My Site becaomse My\ Site. Before this might not has been issued because all values were wrapped with ' hence #56 To test this change (you have to be in production mode) - Set your PLATFORM_NAME to any thing that incldues space - Build the mfe image - Check `document.title` in dev console of any mfe - It will not incldue PLATFORM_NAME After applying this patch, the last step above, should result the PLATFORM_NAME i.e. "Learning | PLATFORM_NAME"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior versions of docker-compose had a bug that did not properly escape quotation marks in env_files, incorrectly including them as characters in the string value. The issue was fixed in docker-compose version 1.26.0. If tutor is run on a system that uses an earlier version of docker-compose, then tutor-mfe functionality gets broken by invalid config values.
This should hopefully avoid the issues discussed here: https://discuss.openedx.org/t/mfe-failing-login-refresh-with-404-error/7716/6