Fix remove old version #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You will never delete all versions if take($keep) it's used. I change to ->take(PHP_INT_MAX) so that it take all records apart first that is skipped. I didn't find a better solution to set limit to "all records". The issue happen if you change keep max versions after already exist some versions. For example you start with max 10, and then you change to max 3, then you will never delete older versions that was already saved before change config. I hope that I explain well myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You will never delete all versions if take($keep) it's used.
I change to ->take(PHP_INT_MAX) so that it take all records apart first that is skipped.
I didn't find a better solution to set limit to "all records".
The issue happen if you change keep max versions after already exist some versions.
For example you start with max 10, and then you change to max 3, then you will never delete older versions that was already saved before change config.
I hope that I explain well myself.