Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.1 #540

Merged
merged 82 commits into from
Nov 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
8700239
Initial test of Jenkinsfile
KevinFHartmann Nov 13, 2019
a802039
Added a file to trigger a change when we commit this to the test branch
KevinFHartmann Nov 13, 2019
1397a81
Bugfix: Renamed second test stage to 'Test Artifactory'
KevinFHartmann Nov 13, 2019
3030647
Bugfix: Added "def" to definition
KevinFHartmann Nov 13, 2019
d1a5ea3
Bugfix: Removed repo variable
KevinFHartmann Nov 13, 2019
d058da2
closer to right
KevinFHartmann Nov 13, 2019
b647e99
Bugfix: Fixed missing paren in Jenkinsfile
KevinFHartmann Nov 13, 2019
aa0d93f
NewIdea: Speed up development by removing everything except the artif…
KevinFHartmann Nov 13, 2019
b17fe7f
Bugfix: Name of artifactory server id is "artifactory"
KevinFHartmann Nov 18, 2019
77f3348
Bugfix: Groovy uses "${var}", not "$var" to interpolate strings.
KevinFHartmann Nov 18, 2019
4a6cb00
Testing whether putting the targets into variables will help anything
KevinFHartmann Nov 18, 2019
07f6118
Bugfix: Groovy single quoted strings don't interpolate!
KevinFHartmann Nov 18, 2019
80a8409
Test: See if this pattern works
KevinFHartmann Nov 18, 2019
f433648
Fixed JSON in spec (I hope)
KevinFHartmann Nov 18, 2019
e348603
- Changed pom version to 0.0.0 so we can clean up after these tests l…
KevinFHartmann Nov 18, 2019
4f15e45
Bugfix: Can't modify pom version number because it's used as a build …
KevinFHartmann Nov 18, 2019
cac439e
Bugfix: Now print out the filespec we're trying to upload, so we can …
KevinFHartmann Nov 18, 2019
0d79ae4
Trying this
KevinFHartmann Nov 19, 2019
ea1fcb1
Change: Put old Jenkinsfile back with maven support... let's see what…
KevinFHartmann Nov 19, 2019
726466f
Bugfix: updated pom.xml to have snapshot
KevinFHartmann Nov 19, 2019
5f0fb41
Bugfix: Removed SNAPSHOT
KevinFHartmann Nov 19, 2019
df08abe
Bugfix: Remove build of tests for now for speed reasons
KevinFHartmann Nov 19, 2019
1cad015
Bugfix: Extra '
KevinFHartmann Nov 19, 2019
3a69484
Bugfix: Trying to omit "tool" parameter to see if the default works
KevinFHartmann Nov 19, 2019
6bf587c
Bugfix: Added a MVN3 maven tool configuration in Jenkins; linked to i…
KevinFHartmann Nov 19, 2019
0684c60
Bugfix: Shouldn't use maven-example/pom.xml as the pom
KevinFHartmann Nov 19, 2019
01ef657
Bugfix: Missing ,
KevinFHartmann Nov 19, 2019
9b5cde1
Added tools section
KevinFHartmann Nov 19, 2019
e04c118
Bugfix: Changed maven to match what the error messages suggest is ava…
KevinFHartmann Nov 19, 2019
84f7f1c
The pipeline claims to install JDK11, then complains it can't find it.
KevinFHartmann Nov 19, 2019
fcbb775
Changed dcc-release to dcc-release-local, in hopes that 'local' is pa…
KevinFHartmann Nov 19, 2019
304b1b2
x
KevinFHartmann Nov 19, 2019
51d4cb0
Changed pom to song/pom.xml
KevinFHartmann Nov 19, 2019
ccc65d6
x
KevinFHartmann Nov 19, 2019
14c485d
Trying with -Dmaven.repo.local
KevinFHartmann Nov 19, 2019
810bd59
Adding SONG lead to the pom not being found
KevinFHartmann Nov 19, 2019
084525b
Tried eliminating the resolver step entirely, since it doesn't work.
KevinFHartmann Nov 19, 2019
d4b7920
Bugfix: Trying to use OpenJDK11 now
KevinFHartmann Nov 19, 2019
a800a93
Trying to use DAO in place of MVN3
KevinFHartmann Nov 19, 2019
b6ee96f
Want to see error message for JDK version again...
KevinFHartmann Nov 19, 2019
d160c56
This will now fail because the maven plugin isn't defined for JDK11, …
KevinFHartmann Nov 19, 2019
a63c720
Changed to agent any
KevinFHartmann Nov 19, 2019
8c1a45e
Let's see what a find tells us...
KevinFHartmann Nov 19, 2019
66651e1
Will this syntax work better?
KevinFHartmann Nov 19, 2019
35faa17
Confirm that we can run java11, but that the plugin wants java8. :-(
KevinFHartmann Nov 19, 2019
563c6b7
Show the version numbers that we're failing to run with.
KevinFHartmann Nov 20, 2019
a75b939
Now, let's see if this failure message lists the java version that we…
KevinFHartmann Nov 20, 2019
9ed37cc
no ls
KevinFHartmann Nov 20, 2019
d1c3b92
Changed mvn config slightly
KevinFHartmann Nov 20, 2019
30ad964
Reverted to rtUpload; wrote hopefully cleaner groovy for the JSON.
KevinFHartmann Nov 20, 2019
8fba27e
Added -SNAPSHOT for the snapshot directory to be happy with us
KevinFHartmann Nov 20, 2019
ce43600
Retrying the trigger
KevinFHartmann Nov 20, 2019
b1c7fcb
Enhancement: Now try to include the pom and jar files, the pom file f…
KevinFHartmann Nov 20, 2019
3163987
Real POM files this time
KevinFHartmann Nov 20, 2019
6b571e5
Fixed syntax
KevinFHartmann Nov 20, 2019
5125729
Please work
KevinFHartmann Nov 20, 2019
22e06e4
Fixed pom path for SONG
KevinFHartmann Nov 20, 2019
3cc3098
Added -SNAPSHOT to song
KevinFHartmann Nov 20, 2019
67ef9d9
Trying to get around sandbox error by putting all the kids in the sam…
KevinFHartmann Nov 20, 2019
4a64bf4
Expect this to give a sandbox error
KevinFHartmann Nov 20, 2019
bc5f836
Fixed braces
KevinFHartmann Nov 20, 2019
af394de
Added -SNAPSHOT to repo branch
KevinFHartmann Nov 20, 2019
d833c10
Changed branch tests to (test)?-develop & (test)?-master
KevinFHartmann Nov 20, 2019
43435cc
Add when conditions
KevinFHartmann Nov 20, 2019
6e8664d
Regexp syntax copied from Jenkins documentation didn't work; trying g…
KevinFHartmann Nov 20, 2019
93b33f9
Merge branch 'test-master' into Define_release_process_for_cleints_to…
KevinFHartmann Nov 20, 2019
05ea7cd
Merge pull request #526 from overture-stack/Define_release_process_fo…
KevinFHartmann Nov 20, 2019
4fe3467
Trying syntax again
KevinFHartmann Nov 20, 2019
6bfd571
Changed to any in when clause
KevinFHartmann Nov 20, 2019
de60d6c
Merge pull request #527 from overture-stack/Define_release_process_fo…
KevinFHartmann Nov 20, 2019
6582687
Merged in deployment code
KevinFHartmann Nov 20, 2019
b59762c
Merge remote-tracking branch 'origin/test-master' into Define_release…
KevinFHartmann Nov 20, 2019
1b55ab3
Removed duplicates
KevinFHartmann Nov 21, 2019
2656dd8
Converted Jenkinsfile to use same code as score.
KevinFHartmann Nov 21, 2019
680640c
Merge branch 'develop' into Define_release_process_for_artifactory_ro…
KevinFHartmann Nov 21, 2019
d3b5020
Merge branch 'develop' into Define_release_process_for_artifactory_ro…
KevinFHartmann Nov 22, 2019
e4bc43b
Updated version numbers
KevinFHartmann Nov 22, 2019
a516325
Merge pull request #537 from overture-stack/Define_release_process_fo…
KevinFHartmann Nov 22, 2019
8be8e62
added bootstrap.properties to classpath and fixed makefile issue
rtisma Nov 26, 2019
cb9b2b1
Merge pull request #538 from overture-stack/fixed-docker-command
rtisma Nov 26, 2019
38dcee0
Release 3.0.1
rtisma Nov 26, 2019
6950a23
Merge branch 'master' into rc/3.0.1
rtisma Nov 26, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ WORKDIR $SONG_HOME
CMD mkdir -p $SONG_HOME $SONG_LOGS \
&& java -Dlog.path=$SONG_LOGS \
-jar $JAR_FILE \
--spring.config.location=classpath:/application.yml
--spring.config.location=classpath:/bootstrap.properties,classpath:/application.yml
2 changes: 1 addition & 1 deletion Dockerfile.dev
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ WORKDIR $SONG_HOME
CMD mkdir -p $SONG_HOME $SONG_LOGS \
&& java -Dlog.path=$SONG_LOGS \
-jar $JAR_FILE \
--spring.config.location=classpath:/application.yml,classpath:/bootstrap.properties
--spring.config.location=classpath:/bootstrap.properties,classpath:/application.yml
107 changes: 79 additions & 28 deletions Jenkinsfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
def commit = "UNKNOWN"
import groovy.json.JsonOutput

def version = "UNKNOWN"
def commit = "UNKNOWN"
def repo = "UNKNOWN"

def pom(path, target) {
return [pattern: "${path}/pom.xml", target: "${target}.pom"]
}

def jar(path, target) {
return [pattern: "${path}/target/*.jar",
target : "${target}.jar",
excludePatterns: ["*-exec.jar"]
]
}

def tar(path, target) {
return [pattern: "${path}/target/*.tar.gz",
target : "${target}-dist.tar.gz"]
}

def runjar(path, target) {
return [pattern: "${path}/target/*-exec.jar",
target : "${target}-exec.jar"]
}

pipeline {
agent {
Expand Down Expand Up @@ -58,7 +82,7 @@ spec:
stage('Test') {
steps {
container('jdk') {
sh "./mvnw test"
sh "./mvnw test package"
}
}
}
Expand Down Expand Up @@ -103,45 +127,72 @@ spec:
}
}

stage('Deploy to Overture QA') {
stage('Destination SNAPSHOT') {
when {
branch "develop"
anyOf {
branch 'develop'
branch 'test-develop'
}
}
steps {
container('helm') {
withCredentials([file(credentialsId:'4ed1e45c-b552-466b-8f86-729402993e3b', variable: 'KUBECONFIG')]) {
sh 'env'
sh 'helm init --client-only'
sh "helm ls --kubeconfig $KUBECONFIG"
sh "helm repo add overture https://overture-stack.github.io/charts-server/"
sh """
helm upgrade --kubeconfig $KUBECONFIG --install --namespace=overture-qa song-overture-qa \\
overture/song --reuse-values --set-string image.tag=${commit}
"""
}
script {
repo = "dcc-snapshot/bio/overture"
}
}
}

stage('Deploy to Overture Staging') {
stage('Destination release') {
when {
branch "master"
anyOf {
branch 'master'
branch 'test-master'
}
}
steps {
container('helm') {
withCredentials([file(credentialsId:'4ed1e45c-b552-466b-8f86-729402993e3b', variable: 'KUBECONFIG')]) {
sh 'env'
sh 'helm init --client-only'
sh "helm ls --kubeconfig $KUBECONFIG"
sh "helm repo add overture https://overture-stack.github.io/charts-server/"
sh """
helm upgrade --kubeconfig $KUBECONFIG --install --namespace=overture-staging song-overture-staging \\
overture/song --reuse-values --set-string image.tag=${version}
"""
}
script {
repo = "dcc-release/bio/overture"
}
}
}

stage('Upload Artifacts') {
when {
anyOf {
branch 'master'
branch 'test-master'
branch 'develop'
branch 'test-develop'
}
}
steps {
script {

project = "song"
versionName = "$version"
subProjects = ['client', 'core', 'server']

files = []
files.add([pattern: "pom.xml", target: "$repo/$project/$versionName/$project-${versionName}.pom"])

for (s in subProjects) {
name = "${project}-$s"
target = "$repo/$name/$versionName/$name-$versionName"
files.add(pom(name, target))
files.add(jar(name, target))

if (s in ['client', 'server']) {
files.add(runjar(name, target))
files.add(tar(name, target))
}
}

fileSet = JsonOutput.toJson([files: files])
pretty = JsonOutput.prettyPrint(fileSet)
print("Uploading files=${pretty}")
}

rtUpload(serverId: 'artifactory', spec: fileSet)
}
}
}
}
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ get-analysis-id:

test-submit: start-song-server _ping_song_server
@echo $(YELLOW)$(INFO_HEADER) "Submitting payload /data/submit/exampleVariantCall.json" $(END)
@$(SONG_CLIENT_CMD) submit -f /data/submit/exampleVariantCall.json |& tee $(SONG_CLIENT_SUBMIT_RESPONSE_FILE)
@$(SONG_CLIENT_CMD) submit -f /data/submit/exampleVariantCall.json | tee $(SONG_CLIENT_SUBMIT_RESPONSE_FILE)
@cat $(SONG_CLIENT_SUBMIT_RESPONSE_FILE) | grep analysisId | sed 's/.*://' | sed 's/"\|,//g' > $(SONG_CLIENT_ANALYSIS_ID_FILE)
@echo $(YELLOW)$(INFO_HEADER) "Successfully submitted. Cached analysisId: " $$($(GET_ANALYSIS_ID_CMD)) $(END)

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<groupId>bio.overture</groupId>
<artifactId>song</artifactId>
<packaging>pom</packaging>
<version>3.0.0</version>
<version>3.0.1</version>
<modules>
<module>song-core</module>
<module>song-java-sdk</module>
Expand Down
6 changes: 3 additions & 3 deletions song-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<parent>
<artifactId>song</artifactId>
<groupId>bio.overture</groupId>
<version>3.0.0</version>
<version>3.0.1</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand All @@ -35,12 +35,12 @@
<dependency>
<groupId>bio.overture</groupId>
<artifactId>song-java-sdk</artifactId>
<version>3.0.0</version>
<version>3.0.1</version>
</dependency>
<dependency>
<groupId>bio.overture</groupId>
<artifactId>song-core</artifactId>
<version>3.0.0</version>
<version>3.0.1</version>
</dependency>

<!-- CLI -->
Expand Down
2 changes: 1 addition & 1 deletion song-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<parent>
<artifactId>song</artifactId>
<groupId>bio.overture</groupId>
<version>3.0.0</version>
<version>3.0.1</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
2 changes: 1 addition & 1 deletion song-java-sdk/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<parent>
<artifactId>song</artifactId>
<groupId>bio.overture</groupId>
<version>3.0.0</version>
<version>3.0.1</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
4 changes: 2 additions & 2 deletions song-server/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<parent>
<artifactId>song</artifactId>
<groupId>bio.overture</groupId>
<version>3.0.0</version>
<version>3.0.1</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand All @@ -37,7 +37,7 @@
<dependency>
<groupId>bio.overture</groupId>
<artifactId>song-core</artifactId>
<version>3.0.0</version>
<version>3.0.1</version>
</dependency>

<!-- Spring -->
Expand Down