updated federatedIdService to locally generate objectids #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinFHartmann
approved these changes
Dec 3, 2019
| @@ -52,13 +53,13 @@ public String create( | |||
| @NonNull String analysisId, @NonNull String studyId, @NonNull FileEntity file) { | |||
| studyService.checkStudyExist(studyId); | |||
|
|
|||
| val result = idService.getFileId(analysisId, file.getFileName()); | |||
| val result = idService.getObjectId(analysisId, file.getFileName()); | |||
There was a problem hiding this comment.
What kinds of objects can an objectId identify?
If it's only "files and index files", we should keep the name as FileId.
If it's "potentially anything", then we should drop the word "object" -- it's just a generic id.
If it's something else, we should try to identify what that something else is, and name it that?
Just a thought...
There was a problem hiding this comment.
yea it should be FileId, but was trying to conform to the icgc notion of objectId. ill change it back to FileId, and possibly in the future change the objectId field in the File entity to fileId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.