Refactor ICGC Bucket Names to SCORe in Docker-Compose and Makefile #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneubank
requested changes
Aug 22, 2024
dev/docker-compose.yml
Outdated
| BUCKET_NAME_OBJECT: oicr.icgc.test | ||
| BUCKET_NAME_STATE: oicr.icgc.test | ||
| BUCKET_NAME_OBJECT: score.data | ||
| BUCKET_NAME_STATE: score.test |
There was a problem hiding this comment.
can we rename this to score.state?
There was a problem hiding this comment.
Looks like in score we made this score.test, missed this detail earlier. I'll update that to make consistent.
There was a problem hiding this comment.
Cancel the above notes... There was a reason they used the same bucket name for both of these buckets... there is mounted directory for the test data and we renamed the bucket to score.data, we would either need to create a directory for the state bucket or reuse the data bucket name.
Therefore, I think its easiest to keep both bucket names the same for the local docker compose setup. Let's update this to BUCKET_NAME_STATE: score.data.
joneubank
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the default bucket names in the Docker-Compose setup from oicr.icgc.test to score.data and score.state to align with the SCORe project. It also updates the Makefile to reference the new bucket names. All instances of oicr.icgc.test in the relevant sections have been replaced with score.data to remove outdated ICGC references and standardize the configuration. #848 #846