Remove ICGC References - score-fs name and type

[joneubank]

Summary of request

Remove ICGC references from Score-FS SotrageFile Store. There are hardcoded strings to name the FS with icgc, we can instead name this after score

Details

score/score-fs/src/main/java/bio/overture/score/fs/StorageFileStore.java

Line 27 in f931ebe

public static final String ICGCFS = "icgcfs";

Rename this as SCORE_FS with the value "scorefs"

score/score-fs/src/main/java/bio/overture/score/fs/StorageFileStore.java

Line 31 in f931ebe

return ICGCFS;

Name can be "score"

Additional context

Check for any references to a StorageFileStore name or type. This is eventually used by the score-client. We need to be sure there is no specific reference to these properties that will require additional logic changes.

[joneubank]

Let's also update the name string while making this change:

score/score-fs/src/main/java/bio/overture/score/fs/StorageFileStore.java

Lines 45 to 47 in f931ebe

	public String name() {
	return "icgc";
	}