Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the constant ICGCFS to SCOREFS #425

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

Azher2Ali
Copy link
Contributor

@Azher2Ali Azher2Ali commented Jul 10, 2024

Rename the Constant: #420

The constant ICGCFS was renamed to SCOREFS. This means anywhere ICGCFS was used, it is now replaced by SCOREFS and The value assigned to the constant was changed from "icgcfs" to "scorefs" and the return statement was modified to return the new constant SCOREFS instead of the old constant ICGCFS

@joneubank joneubank self-requested a review July 10, 2024 18:39
@Azher2Ali Azher2Ali requested a review from leoraba July 11, 2024 16:08
@joneubank
Copy link
Contributor

Looks good. While we're makign changes to this file can we also update the getName response?

public String name() {
return "icgc";
}

@Azher2Ali Azher2Ali requested review from joneubank and removed request for joneubank July 11, 2024 20:30
@Azher2Ali Azher2Ali merged commit cc44514 into develop Jul 18, 2024
2 checks passed
@Azher2Ali Azher2Ali deleted the refactor/rename-constant branch July 18, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants