fix: Deadlock fix with song and score #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When song tries to publish, it calls the download endpoint on score. Since the analysis is currently UNPUBLISHED and score will only allow downloads for PUBLISHED files, therefore song cannot publish because score only allows published files to be download. Fix was to add a new path param, that will return object spec WITHOUT urls.
rtisma
changed the title
andricDu
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When song tries to publish, it calls the download endpoint on score. Since the analysis is currently
UNPUBLISHED and score will only allow downloads for PUBLISHED files, therefore song cannot publish
because score only allows published files to be download. Fix was to add a new path param, that will
return object spec WITHOUT urls.
Test was not included, as it required stubbing out the entire universe.
related to #140