Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminating Error messaging referencing ICGC #454

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

Azher2Ali
Copy link
Contributor

@Azher2Ali Azher2Ali commented Jul 24, 2024

Updated error messaging in DownloadCommand.java to remove references to ICGC and provide a more concise message.

Details:

Shortened the error message in score/score-client/src/main/java/bio/overture/score/client/command/DownloadCommand.java:
Updated the message to: "Please ensure you are using a tab-delimited text file manifest." #444

Copy link
Contributor

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the ticket:

Please ensure you are using a tab-delimited text file manifest.

Copy link
Contributor

@leoraba leoraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Azher2Ali Azher2Ali requested a review from leoraba August 9, 2024 20:29
@Azher2Ali Azher2Ali merged commit c846d1e into develop Aug 9, 2024
2 checks passed
@Azher2Ali Azher2Ali deleted the refactor/error-message branch August 9, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants