Remove Hardcoded Profiles and Default URLs from SCORe Client #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneubank
requested changes
Aug 12, 2024
score-client/src/main/java/bio/overture/score/client/command/InfoCommand.java
Outdated
Show resolved
Hide resolved
joneubank
previously approved these changes
Aug 12, 2024
joneubank
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the refactoring of the SCORe client to enhance its flexibility by removing hardcoded configurations that limit the ability to connect to various SCORe and Song servers. The following changes were made:
Remove Dedicated Profiles:
The kf and oicr profiles have been removed from application.yml, along with their hardcoded server URLs.
The application is now designed to rely on user-provided CLI arguments or configurations to specify the locations of storage and metadata servers.
Remove Default URLs:
The default values for storage.url and metadata.url have been removed from application.yml.
These lines are now commented out, indicating that the application will look for these values, but they must be provided by the user.
Remove ProfileRepoValidator and Associated Code:
The ProfileRepoValidator has been removed as it was used to validate specific project profile names, which are no longer relevant.
Consequently, the validateManifest() function in AbstractClientCommand and all its references have also been removed.
Remove Profile Annotation from ScoreStorageService:
After removing the kf profile, the Profile annotation in ScoreStorageService has been removed, as it no longer serves a purpose.
These changes simplify the configuration process and make the client more versatile, allowing it to connect to any specified servers without relying on predefined profiles. #462