Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminating kf profile from the codebase #476

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

Azher2Ali
Copy link
Contributor

@Azher2Ali Azher2Ali commented Aug 14, 2024

This update removes the KF profile and all related alternate classes from the codebase as the kf profile is no longer supported by Score. The following changes have been made:

Removal of KF Metadata Services:

Removed the metadata/kf/KFMetadataService class.

Deleted the entire metadata/kf directory.

Removed the @Profile("!kf") annotation from LegacyMetadataService.

Removal of KF Annotations from CLI Commands:

Removed @Profile("!kf") from MountCommand, UploadCommand, and ViewCommand.

Clean-Up of Application Configuration:

Removed all KF-related configurations from the application.yml files in both the main and test resource directories. This includes:

KF-specific properties under the common profile.

The entire active profile configuration for KF #461

Complete Removal of KF Storage Components
Summary:

With the full removal of Kids First (KF) project elements from the SCORe client, we have deleted the entire storage folder associated with KF. This cleanup eliminates unnecessary code without impacting the functionality of the application.

Details:

Directory Removed:
The entire kf storage folder and its contents located at score-client/src/main/java/bio/overture/score/client/storage/kf have been deleted./

  • Service Relocation:

The ScoreStorageService has been moved into the parent package (bio.overture.score.client.storage), aligning it with the AbstractStorageService.

  • Profile Removal:

The KF profile has been removed from ScoreStorageService (#460).

  • Configuration Cleanup:

#464

@joneubank joneubank removed the request for review from UmmulkiramR August 22, 2024 17:29
@Azher2Ali Azher2Ali merged commit 03e4931 into develop Aug 22, 2024
2 checks passed
@Azher2Ali Azher2Ali deleted the refactor/kf_profile branch August 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants