Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a datasource for vps (on the dedicated_server model) #126

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

gaetanfl
Copy link
Contributor

@gaetanfl gaetanfl commented Jan 8, 2020

This is the first step to have feature parity between vps and dedicated servers.

@yanndegat
Copy link
Collaborator

hi @gaetanfl

thank you very much for contributing this new feature

it's seems to me though that the tests are failing.

are they passing on your side ?

@gaetanfl
Copy link
Contributor Author

You're right, it's now fixed

@gaetanfl
Copy link
Contributor Author

Hi @yanndegat is there anything I can do to help this PR be merged ?

@yanndegat
Copy link
Collaborator

hi @gaetanfl

firstable thank you so much for all the time you spent contrubuting this new resource.

i just have to find some time to try to run the testacc but to do so, i have to order a VPS,
and then make the review.

i dont have much time for now, but i'll try to do so in the next couple weeks

can you wait a few more weeks ?

@gaetanfl
Copy link
Contributor Author

Sure, it can wait a few weeks, I can produce the binary and use it on my side

@gaetanfl
Copy link
Contributor Author

Hi @yanndegat , I finally took the time to test it with my inventory and it works fine. Did you have time on your side to do some tests ?

@yanndegat
Copy link
Collaborator

ok

thank you very much @gaetanfl

merging this PR

@yanndegat yanndegat merged commit 6efc47a into ovh:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants