Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ovh_iploadbalancing_tcp_farm resource #32

Merged
merged 1 commit into from
May 22, 2018

Conversation

goblain
Copy link
Contributor

@goblain goblain commented May 17, 2018

No description provided.

@goblain goblain force-pushed the iploadbalancing_tcp_farm branch 3 times, most recently from 7a6d1e7 to 6effb63 Compare May 17, 2018 09:18
@yanndegat
Copy link
Collaborator

hi @goblain

that's "super dope" ! thank you very much
this resource is expected by a lot of people

we have to add acc tests along with it and complete the doc entries

do you think you could do it ?

i'll see on my side how i can deal with hashicorp & ovh so that we would have an iplb
instance dedicated for acc tests

@goblain goblain force-pushed the iploadbalancing_tcp_farm branch 3 times, most recently from 61cd65f to 34bffdf Compare May 18, 2018 11:38
@goblain
Copy link
Contributor Author

goblain commented May 18, 2018

docs and basic test added

OVH_IPLB_SERVICE env providing loadbalancing service name is required for the acc test to work as expected

@eliecharra
Copy link
Contributor

i'll see on my side how i can deal with hashicorp & ovh so that we would have an iplb
instance dedicated for acc tests

@yanndegat I'm thinking about adding iplb routing resources in a second time but this require Offer pack 2 (with advanced features), which is quite expensive (200€/mo) Are you aware of what kind of service hashicorp could negotiate for integration tests ?

@yanndegat
Copy link
Collaborator

hi @eliecharra

i actually work @ovh, i have to deal with some folks internally to see what is possible or not

@eliecharra
Copy link
Contributor

eliecharra commented May 18, 2018

@yanndegat Sounds great !

Anyway thanks a lot @goblain for this killer feature 👍

@yanndegat
Copy link
Collaborator

news is: acc test on hc's ci infra should be solved next week

until then ill try to run all this on my infra

again thanks a lot @goblain for all the hard work

@yanndegat yanndegat merged commit 6750160 into ovh:master May 22, 2018
@yanndegat
Copy link
Collaborator

thanks a log @goblain

thats wonderful job

an iplb should be available within the hashicorp test account by the end of this week
i'll check with @tombuildsstuff to update the env vars accordingly once done.

@eliecharra
Copy link
Contributor

eliecharra commented May 22, 2018

@yanndegat How could we contribute to make this feature visible on hashicorp website.

As said in #24 many resources are missing.

@yanndegat
Copy link
Collaborator

hi @eliecharra

it will be once the provider is released, as long as the doc isnt broken ;)

i think once we will have merge the vps, and the iplb tcp farm we will ask hc for a release
what do you think ?

@eliecharra
Copy link
Contributor

i think once we will have merge the vps, and the iplb tcp farm we will ask hc for a release

Nice 👍

I'll try to add a ovh_iploadbalancing_route afterwards.

@goblain
Copy link
Contributor Author

goblain commented May 22, 2018

for a complete release it would be nice to do it in boundle with tcp_farm_server and tcp_frontend which forms a reasonable set of resources for setting up a tcp loadbalancing service top to bottom.

The first one is more or less just rebase and docs away, the later I already started but needs a day or two more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants