Impl Dedicated Nasha #349

FlorianPerrot · 2022-12-20T13:12:02Z

Description

Partial implementation NASHA resources / data with test and docs.

Thanks @goblain. Author of first implementation. see : #44

Type of change

Add Resources :

ovh_dedicated_nasha_partition
ovh_dedicated_nasha_partition_access
ovh_dedicated_nasha_partition_snapshot

Add Data:

ovh_dedicated_nasha

scraly · 2022-12-27T12:58:22Z

Thanks :)
In every page of OVHcloud this service is called "HA-NAS" in english (or NAS-HA in french ;-) ).
So I added a suggestion of modification in all the PR (code and documentation) with this correct product name :).

scraly

Several suggestions about the name of the product :)

scraly · 2022-12-27T11:58:24Z

website/docs/d/dedicated_nasha.html.markdown

+
+# ovh_dedicated_nasha (Data Source)
+
+Use this data source to retrieve information about a dedicated nasha.


Suggested change

Use this data source to retrieve information about a dedicated nasha.

Use this data source to retrieve information about a dedicated HA-NAS.

scraly · 2022-12-27T11:58:34Z

website/docs/d/dedicated_nasha.html.markdown

+page_title: "OVH: dedicated_nasha"
+sidebar_current: "docs-ovh-datasource-dedicated-nasha"
+description: |-
+  Get information of a dedicated nasha.


Suggested change

Get information of a dedicated nasha.

Get information of a dedicated HA-NAS.

scraly · 2022-12-27T12:00:47Z

website/docs/d/dedicated_nasha.html.markdown

+
+## Argument Reference
+
+* `service_name` - (Required) The service_name of your dedicated NASHA.


Suggested change

* `service_name` - (Required) The service_name of your dedicated NASHA.

* `service_name` - (Required) The service_name of your dedicated HA-NAS.

scraly · 2022-12-27T12:00:56Z

website/docs/d/dedicated_nasha.html.markdown

+
+## Attributes Reference
+
+`id` is set with the service_name of the dedicated nasha.


Suggested change

`id` is set with the service_name of the dedicated nasha.

`id` is set with the service_name of the dedicated HA-NAS.

scraly · 2022-12-27T12:01:09Z

website/docs/d/dedicated_nasha.html.markdown

+In addition, the following attributes are exported:
+
+* `service_name` - The storage service name
+* `can_create_partition` - True, if partition creation is allowed on this nas HA


Suggested change

* `can_create_partition` - True, if partition creation is allowed on this nas HA

* `can_create_partition` - True, if partition creation is allowed on this HA-NAS

scraly · 2022-12-27T13:08:26Z

ovh/resource_dedicated_nasha_test.go

+			return fmt.Errorf("calling GET %s :\n\t %s", endpoint, err.Error())
+		}
+
+		fmt.Printf("NASHA partition snapshot : %+v\n", partitionSnapshotResponse)


Suggested change

fmt.Printf("NASHA partition snapshot : %+v\n", partitionSnapshotResponse)

fmt.Printf("HA-NAS partition snapshot: %+v\n", partitionSnapshotResponse)

scraly · 2022-12-27T13:08:32Z

ovh/resource_dedicated_nasha_test.go

+			return fmt.Errorf("calling GET %s :\n\t %s", endpoint, err.Error())
+		}
+
+		fmt.Printf("NASHA partition : %+v\n", partitionResponse)


Suggested change

fmt.Printf("NASHA partition : %+v\n", partitionResponse)

fmt.Printf("HA-NAS partition: %+v\n", partitionResponse)

scraly · 2022-12-27T13:08:49Z

ovh/resource_dedicated_nasha_test.go

+			return fmt.Errorf("calling GET %s :\n\t %s", endpoint, err.Error())
+		}
+
+		fmt.Printf("NASHA partition access : %+v\n", partitionAccessResponse)


Suggested change

fmt.Printf("NASHA partition access : %+v\n", partitionAccessResponse)

fmt.Printf("HA-NAS partition access: %+v\n", partitionAccessResponse)

scraly · 2022-12-27T13:09:11Z

ovh/resource_dedicated_nasha_test.go

+		partitionSnapshotResponse := &DedicatedNASHAPartitionSnapshot{}
+		err := config.OVHClient.Get(endpoint, partitionSnapshotResponse)
+		if err != nil {
+			return fmt.Errorf("calling GET %s :\n\t %s", endpoint, err.Error())


Suggested change

return fmt.Errorf("calling GET %s :\n\t %s", endpoint, err.Error())

return fmt.Errorf("calling GET %s:\n\t %s", endpoint, err.Error())

scraly · 2022-12-27T13:09:32Z

ovh/resource_dedicated_nasha_test.go

+
+		err := config.OVHClient.Get(endpoint, nil)
+		if err == nil {
+			return fmt.Errorf("NASHA Partition (%s) still exists", parititionName)


Suggested change

return fmt.Errorf("NASHA Partition (%s) still exists", parititionName)

return fmt.Errorf("HA-NAS Partition (%s) still exists", partitionName)

FlorianPerrot · 2022-12-27T13:31:45Z

Thanks @scraly for review my PR.
I can replace on documentation and log message. But on "api.ovh.com" real entrypoint is called "/dedicated/nasha" to have a link between terraform resources and OVH resources i kept dedicated_nasha.

scraly · 2022-12-27T13:43:00Z

Yes the name of the resource and datasource are good, because it matches with the API endpoint but I think we need to be homogeneous with the product name: https://www.ovhcloud.com/en-gb/storage-solutions/nas-ha/ :)

scraly

fix parititionName to partitionName

scraly · 2022-12-27T13:47:59Z

ovh/resource_dedicated_nasha_test.go

+		}
+
+		serviceName := nashaPartitionAccessResource.Primary.Attributes["service_name"]
+		parititionName := nashaPartitionAccessResource.Primary.Attributes["name"]


Suggested change

parititionName := nashaPartitionAccessResource.Primary.Attributes["name"]

partitionName := nashaPartitionAccessResource.Primary.Attributes["name"]

scraly · 2022-12-27T13:48:07Z

ovh/resource_dedicated_nasha_test.go

+		parititionName := nashaPartitionAccessResource.Primary.Attributes["name"]
+
+		config := testAccProvider.Meta().(*Config)
+		endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, parititionName)


Suggested change

endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, parititionName)

endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, partitionName)

scraly · 2022-12-27T13:49:11Z

ovh/resource_dedicated_nasha_test.go

+		parititionName := nashaPartitionAccessResource.Primary.Attributes["name"]
+
+		config := testAccProvider.Meta().(*Config)
+		endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, parititionName)


Suggested change

endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, parititionName)

endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, partitionName)

scraly · 2022-12-27T13:49:18Z

ovh/resource_dedicated_nasha_test.go

+		parititionName := nashaPartitionAccessResource.Primary.Attributes["name"]
+
+		config := testAccProvider.Meta().(*Config)
+		endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, parititionName)


Suggested change

endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, parititionName)

endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, partitionName)

scraly · 2022-12-27T15:16:48Z

Thank you,
but some suggestions are not fixed for the moment :)

…ot necessary env

FlorianPerrot · 2022-12-27T15:27:52Z

Fixed!
Sorry for this.

scraly

I added some suggestions again :-)

Moreover, the creation of resources are working :

$ terraform apply
data.ovh_dedicated_nasha.foo: Reading...
ovh_dedicated_nasha_partition.my-partition: Refreshing state... [id=zpool-xxxxxx/my-partition]
data.ovh_dedicated_nasha.foo: Read complete after 1s [id=zpool-xxxxxx]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # ovh_dedicated_nasha_partition_access.my-partition will be created
  + resource "ovh_dedicated_nasha_partition_access" "my-partition" {
      + id             = (known after apply)
      + ip             = "123.123.123.123/32"
      + partition_name = "my-partition"
      + service_name   = "zpool-xxxxxx"
      + type           = "readwrite"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

ovh_dedicated_nasha_partition_access.my-partition: Creating...
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [10s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [20s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [30s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [40s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [50s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Creation complete after 51s [id=zpool-xxxxxx/my-partition/123.123.123.123/32]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

But I have an issue when I want to "read" the partition_access :

$ terraform apply
data.ovh_dedicated_nasha.foo: Reading...
ovh_dedicated_nasha_partition_access.my-partition: Refreshing state... [id=zpool-xxxx/my-partition/123.123.123.123/32]
ovh_dedicated_nasha_partition.my-partition: Refreshing state... [id=zpool-xxxx/my-partition]
data.ovh_dedicated_nasha.foo: Read complete after 1s [id=zpool-xxxx]
╷
│ Error: cant parse access partition id: zpool-xxxx/my-partition/123.123.123.123/32
│
│   with ovh_dedicated_nasha_partition_access.my-partition,
│   on pr349.tf line 12, in resource "ovh_dedicated_nasha_partition_access" "my-partition":
│   12: resource "ovh_dedicated_nasha_partition_access" "my-partition" {
│

scraly · 2022-12-28T08:26:16Z

website/docs/d/dedicated_nasha.html.markdown

+* `ip` - Access IP of HA-NAS
+* `monitored` - Send an email to customer if any issue is detected
+* `zpool_capacity` - percentage of HA-NAS space used in %
+* `zpool_size` - the size of the HA-NAS in Go


The size is in ... bytes, in GB? :-)

scraly · 2022-12-28T08:27:40Z

website/docs/r/dedicated_nasha_partition.markdown

+```
+resource "ovh_dedicated_nasha_partition" "foo" {
+  service_name = "zpool-12345"
+  name = "foo"


Suggested change

name = "foo"

name = "my-partition"

scraly · 2022-12-28T08:28:29Z

website/docs/r/dedicated_nasha_partition_access.markdown

+## Import
+
+HA-NAS partition access can be imported using the `{service_name}/{partition_name}/{ip}`, e.g.  
+`$ terraform import ovh_dedicated_nasha_partition_access.foo zpool-12345/foo/123.123.123.123%2F32`


Suggested change

`$ terraform import ovh_dedicated_nasha_partition_access.foo zpool-12345/foo/123.123.123.123%2F32`

`$ terraform import ovh_dedicated_nasha_partition_access.foo zpool-12345/my-partition/123.123.123.123%2F32`

scraly · 2022-12-28T08:28:49Z

website/docs/r/dedicated_nasha_partition.markdown

+## Import
+
+HA-NAS can be imported using the `{service_name}/{name}`, e.g.  
+`$ terraform import ovh_dedicated_nasha_partition.foo zpool-12345/foo`


Suggested change

`$ terraform import ovh_dedicated_nasha_partition.foo zpool-12345/foo`

`$ terraform import ovh_dedicated_nasha_partition.foo zpool-12345/my-partition`

scraly · 2022-12-28T08:30:38Z

website/docs/r/dedicated_nasha_partition_access.markdown

+  service_name = "zpool-12345"
+  partition_name = "foo"
+  ip = "123.123.123.123/32"
+  protocol = "NFS"


Suggested change

protocol = "NFS"

type = "readwrite"

scraly · 2022-12-28T08:33:03Z

website/docs/r/dedicated_nasha_partition_snapshot.markdown

+```
+resource "ovh_dedicated_nasha_partition_snapshot" "foo" {
+  service_name = "zpool-12345"
+  partition_name = "foo"


Suggested change

partition_name = "foo"

partition_name = "my-partition"

scraly · 2022-12-28T08:33:04Z

website/docs/r/dedicated_nasha_partition_snapshot.markdown

+## Example Usage
+
+```
+resource "ovh_dedicated_nasha_partition_snapshot" "foo" {


Suggested change

resource "ovh_dedicated_nasha_partition_snapshot" "foo" {

resource "ovh_dedicated_nasha_partition_snapshot" "my-partition" {

scraly · 2022-12-28T08:33:16Z

website/docs/r/dedicated_nasha_partition_snapshot.markdown

+
+The following arguments are supported:
+
+* `service_name` - (Required) The internal name of your HA-NAS (it has to be ordered via OVH interface)


Suggested change

* `service_name` - (Required) The internal name of your HA-NAS (it has to be ordered via OVH interface)

* `service_name` - (Required) The internal name of your HA-NAS (it has to be ordered via OVHcloud interface)

scraly · 2022-12-28T08:33:23Z

website/docs/r/dedicated_nasha_partition_snapshot.markdown

+
+The following arguments are supported:
+
+* `service_name` - (Required) The internal name of your HA-NAS (it has to be ordered via OVH interface)


Suggested change

* `service_name` - (Required) The internal name of your HA-NAS (it has to be ordered via OVH interface)

* `service_name` - (Required) The internal name of your HA-NAS (it has to be ordered via OVHcloud interface)

scraly · 2022-12-28T08:33:41Z

website/docs/r/dedicated_nasha_partition_snapshot.markdown

+## Import
+
+HA-NAS partition snapshot can be imported using the `{service_name}/{partition_name}/{type}`, e.g.  
+`$ terraform import ovh_dedicated_nasha_partition_snapshot.foo zpool-12345/foo/day-3`


Suggested change

`$ terraform import ovh_dedicated_nasha_partition_snapshot.foo zpool-12345/foo/day-3`

`$ terraform import ovh_dedicated_nasha_partition_snapshot.foo zpool-12345/my-partition/day-3`

scraly

I added some suggestions again :-)

Moreover, the creation of resources are working :

$ terraform apply
data.ovh_dedicated_nasha.foo: Reading...
ovh_dedicated_nasha_partition.my-partition: Refreshing state... [id=zpool-xxxxxx/my-partition]
data.ovh_dedicated_nasha.foo: Read complete after 1s [id=zpool-xxxxxx]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # ovh_dedicated_nasha_partition_access.my-partition will be created
  + resource "ovh_dedicated_nasha_partition_access" "my-partition" {
      + id             = (known after apply)
      + ip             = "123.123.123.123/32"
      + partition_name = "my-partition"
      + service_name   = "zpool-xxxxxx"
      + type           = "readwrite"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

ovh_dedicated_nasha_partition_access.my-partition: Creating...
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [10s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [20s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [30s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [40s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Still creating... [50s elapsed]
ovh_dedicated_nasha_partition_access.my-partition: Creation complete after 51s [id=zpool-xxxxxx/my-partition/123.123.123.123/32]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

But I have an issue when I want to "read" the partition_access :

$ terraform apply
data.ovh_dedicated_nasha.foo: Reading...
ovh_dedicated_nasha_partition_access.my-partition: Refreshing state... [id=zpool-xxxx/my-partition/123.123.123.123/32]
ovh_dedicated_nasha_partition.my-partition: Refreshing state... [id=zpool-xxxx/my-partition]
data.ovh_dedicated_nasha.foo: Read complete after 1s [id=zpool-xxxx]
╷
│ Error: cant parse access partition id: zpool-xxxx/my-partition/123.123.123.123/32
│
│   with ovh_dedicated_nasha_partition_access.my-partition,
│   on pr349.tf line 12, in resource "ovh_dedicated_nasha_partition_access" "my-partition":
│   12: resource "ovh_dedicated_nasha_partition_access" "my-partition" {
│

ovh/resource_dedicated_nasha_partition_access.go

FlorianPerrot · 2022-12-28T09:39:18Z

I fixed this issue yesterday. here: 9940526
Can you retry your test with this fix?

Acceptance test case works for me. If I'm not mistaken, he should also work for your test.

ovh/resource_dedicated_nasha_partition_access.go

scraly · 2022-12-28T09:44:29Z

I fixed this issue yesterday. here: 9940526 Can you retry your test with this fix?

Acceptance test case works for me. If I'm not mistaken, he should also work for your test.

After your fix, I have still this issue in the read access:

$ terraform destroy
data.ovh_dedicated_nasha.foo: Reading...
ovh_dedicated_nasha_partition_snapshot.my-partition: Refreshing state... [id=zpool-xxxxx/my-partition/day-3]
ovh_dedicated_nasha_partition_access.my-partition: Refreshing state... [id=zpool-xxxxx/my-partition/123.123.123.123/32]
ovh_dedicated_nasha_partition.my-partition: Refreshing state... [id=zpool-xxxxx/my-partition]
data.ovh_dedicated_nasha.foo: Read complete after 0s [id=zpool-xxxxx]
╷
│ Error: can't parse access partition ID: zpool-xxxxx/my-partition/123.123.123.123/32
│
│   with ovh_dedicated_nasha_partition_access.my-partition,
│   on pr349.tf line 12, in resource "ovh_dedicated_nasha_partition_access" "my-partition":
│   12: resource "ovh_dedicated_nasha_partition_access" "my-partition" {
│

FlorianPerrot · 2022-12-28T10:02:35Z

You should retry without context. In your case the access resource have a bad ID, generated before my fix.

…rtition

scraly

Tests are now Ok for me :-)

So please look at every suggestions have done and commit them.
Thank you

scraly · 2022-12-28T12:51:53Z

website/docs/d/dedicated_nasha.html.markdown

+## Example Usage
+
+```hcl
+data "ovh_dedicated_nasha" "foo" {


Suggested change

data "ovh_dedicated_nasha" "foo" {

data "ovh_dedicated_nasha" "my-nas-ha" {

scraly · 2022-12-28T12:52:24Z

website/docs/r/dedicated_nasha_partition.markdown

+## Import
+
+HA-NAS can be imported using the `{service_name}/{name}`, e.g.  
+`$ terraform import ovh_dedicated_nasha_partition.foo zpool-12345/my-partition`


Suggested change

`$ terraform import ovh_dedicated_nasha_partition.foo zpool-12345/my-partition`

`$ terraform import ovh_dedicated_nasha_partition.my-partition zpool-12345/my-partition`

scraly · 2022-12-28T12:54:35Z

website/docs/r/dedicated_nasha_partition.markdown

+## Import
+
+HA-NAS can be imported using the `{service_name}/{name}`, e.g.  
+`$ terraform import ovh_dedicated_nasha_partition.foo zpool-12345/my-partition`


Suggested change

`$ terraform import ovh_dedicated_nasha_partition.foo zpool-12345/my-partition`

`$ terraform import ovh_dedicated_nasha_partition.my-partition zpool-12345/my-partition`

scraly · 2022-12-28T12:54:56Z

website/docs/r/dedicated_nasha_partition_access.markdown

+## Import
+
+HA-NAS partition access can be imported using the `{service_name}/{partition_name}/{ip}`, e.g.  
+`$ terraform import ovh_dedicated_nasha_partition_access.foo zpool-12345/my-partition/123.123.123.123%2F32`


Suggested change

`$ terraform import ovh_dedicated_nasha_partition_access.foo zpool-12345/my-partition/123.123.123.123%2F32`

`$ terraform import ovh_dedicated_nasha_partition_access.my-partition zpool-12345/my-partition/123.123.123.123%2F32`

scraly · 2022-12-28T12:56:12Z

website/docs/r/dedicated_nasha_partition_snapshot.markdown

+## Import
+
+HA-NAS partition snapshot can be imported using the `{service_name}/{partition_name}/{type}`, e.g.  
+`$ terraform import ovh_dedicated_nasha_partition_snapshot.foo zpool-12345/my-partition/day-3`


Suggested change

`$ terraform import ovh_dedicated_nasha_partition_snapshot.foo zpool-12345/my-partition/day-3`

`$ terraform import ovh_dedicated_nasha_partition_snapshot.my-partition zpool-12345/my-partition/day-3`

scraly · 2022-12-28T15:31:48Z

Good new feature, it's OK for me :)

Florian Perrot added 8 commits December 19, 2022 17:47

feat: impl NASHA ressource

468c802

feat(nasha): resource Dedicated NASHA snapshot

870ab8b

feat(nasha): Change resource id generation to be compatible with import

4909f88

feat(nasha): add snapshot resource on provider

0ae65e7

feat(nasha): resource testing

f5442c3

feat(nasha): data dedicated nasha

5451be2

doc(nasha)

e2f648c

feat(nasha): allow nasha_paritition_access import

e3905e4

scraly requested changes Dec 27, 2022

View reviewed changes

FlorianPerrot force-pushed the nasha branch 2 times, most recently from b92be39 to 5651f70 Compare December 27, 2022 15:07

FlorianPerrot requested a review from scraly December 27, 2022 15:09

Florian Perrot added 3 commits December 27, 2022 16:22

style: rename NASHA to HA-NAS

0b6104d

doc/test: Add doc for OVH_NASHA_SERVICE_TEST testing env and remove n…

6fe2099

…ot necessary env

fix(nasha): Escape ipsubnet on resource ID

9940526

FlorianPerrot force-pushed the nasha branch from 5651f70 to 9940526 Compare December 27, 2022 15:23

scraly requested changes Dec 28, 2022

View reviewed changes

ovh/resource_dedicated_nasha_partition_access.go Show resolved Hide resolved

doc(nasha): rewording, fix zpool_size unit

506f31a

scraly requested changes Dec 28, 2022

View reviewed changes

ovh/resource_dedicated_nasha_partition_access.go Show resolved Hide resolved

doc(nasha): rewording, add description argument on dedicated_nasha_pa…

4c85082

…rtition

scraly requested changes Dec 28, 2022

View reviewed changes

doc(nasha): rewording

da2ba9a

FlorianPerrot requested a review from scraly December 28, 2022 14:14

scraly approved these changes Dec 28, 2022

View reviewed changes

scraly added the 0.26.0 label Dec 28, 2022

scraly merged commit 89e6eb6 into ovh:master Dec 28, 2022


		# ovh_dedicated_nasha (Data Source)

		Use this data source to retrieve information about a dedicated nasha.

	Get information of a dedicated nasha.
	Get information of a dedicated HA-NAS.


		## Argument Reference

		* `service_name` - (Required) The service_name of your dedicated NASHA.


		## Attributes Reference

		`id` is set with the service_name of the dedicated nasha.

	* `can_create_partition` - True, if partition creation is allowed on this nas HA
	* `can_create_partition` - True, if partition creation is allowed on this HA-NAS

	fmt.Printf("NASHA partition snapshot : %+v\n", partitionSnapshotResponse)
	fmt.Printf("HA-NAS partition snapshot: %+v\n", partitionSnapshotResponse)

	fmt.Printf("NASHA partition : %+v\n", partitionResponse)
	fmt.Printf("HA-NAS partition: %+v\n", partitionResponse)

	fmt.Printf("NASHA partition access : %+v\n", partitionAccessResponse)
	fmt.Printf("HA-NAS partition access: %+v\n", partitionAccessResponse)

	return fmt.Errorf("calling GET %s :\n\t %s", endpoint, err.Error())
	return fmt.Errorf("calling GET %s:\n\t %s", endpoint, err.Error())

	return fmt.Errorf("NASHA Partition (%s) still exists", parititionName)
	return fmt.Errorf("HA-NAS Partition (%s) still exists", partitionName)

	parititionName := nashaPartitionAccessResource.Primary.Attributes["name"]
	partitionName := nashaPartitionAccessResource.Primary.Attributes["name"]

	endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, parititionName)
	endpoint := fmt.Sprintf("/dedicated/nasha/%s/partition/%s", serviceName, partitionName)

	`$ terraform import ovh_dedicated_nasha_partition_access.foo zpool-12345/foo/123.123.123.123%2F32`
	`$ terraform import ovh_dedicated_nasha_partition_access.foo zpool-12345/my-partition/123.123.123.123%2F32`

	resource "ovh_dedicated_nasha_partition_snapshot" "foo" {
	resource "ovh_dedicated_nasha_partition_snapshot" "my-partition" {


		The following arguments are supported:

		* `service_name` - (Required) The internal name of your HA-NAS (it has to be ordered via OVH interface)

	data "ovh_dedicated_nasha" "foo" {
	data "ovh_dedicated_nasha" "my-nas-ha" {

Impl Dedicated Nasha #349

Impl Dedicated Nasha #349

Conversation

FlorianPerrot commented Dec 20, 2022

Description

Type of change

scraly commented Dec 27, 2022 • edited Loading

scraly left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scraly Dec 27, 2022 • edited Loading

Choose a reason for hiding this comment

FlorianPerrot commented Dec 27, 2022

scraly commented Dec 27, 2022

scraly left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scraly commented Dec 27, 2022

FlorianPerrot commented Dec 27, 2022

scraly left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scraly left a comment

Choose a reason for hiding this comment

FlorianPerrot commented Dec 28, 2022

scraly commented Dec 28, 2022

FlorianPerrot commented Dec 28, 2022

scraly left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scraly commented Dec 28, 2022

scraly commented Dec 27, 2022 •

edited

Loading

scraly Dec 27, 2022 •

edited

Loading