Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-plugin-sdk + go versions bump #406

Merged
merged 20 commits into from
Apr 17, 2023
Merged

terraform-plugin-sdk + go versions bump #406

merged 20 commits into from
Apr 17, 2023

Conversation

yomovh
Copy link
Member

@yomovh yomovh commented Apr 11, 2023

Description

Spring cleaning PR:

  • go version upgrade to 1.19.0
  • terraform-plugin-sdk upgrade to 2.24.0
  • Minor changes to clean the testacc

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Full run of the testAcc

Test Configuration:
See .cds directory

Hashicorp does not promote anymore a specific test for import but to implement it as a TestStep see https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/import

This required to bump sdk to 2.24 since this kind of test assessment (import test when the state has a datasource) failed with tf >1.3.0 see hashicorp/terraform-provider-aws#27049
…ved and it is not recommended anymore to have a specific test file for the import
@yomovh yomovh changed the title Refactoring sdk go terraform-plugin-sdk + go versions bump Apr 11, 2023
@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 11, 2023

CDS Report terraform-provider-ovh-check#1598.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 11, 2023

CDS Report terraform-provider-ovh-testacc#1598.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 12, 2023

CDS Report terraform-provider-ovh-check#1600.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 12, 2023

CDS Report terraform-provider-ovh-testacc#1600.0 ✘
*

  • checks ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 13, 2023

CDS Report terraform-provider-ovh-check#1602.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 13, 2023

CDS Report terraform-provider-ovh-testacc#1602.0 ✘
*

  • checks ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 14, 2023

CDS Report terraform-provider-ovh-check#1606.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 14, 2023

CDS Report terraform-provider-ovh-testacc#1606.0 ✘
*

  • checks ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 17, 2023

CDS Report terraform-provider-ovh-check#1611.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 17, 2023

CDS Report terraform-provider-ovh-check#1610.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 17, 2023

CDS Report terraform-provider-ovh-testacc#1611.0 ■
*

  • checks ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 17, 2023

CDS Report terraform-provider-ovh-testacc#1611.0 ■
*

  • checks ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 17, 2023

CDS Report terraform-provider-ovh-check#1611.0 ✔
*

  • checks ✔

@yomovh yomovh merged commit a451b64 into master Apr 17, 2023
@scraly scraly added the 0.30.0 label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants