add retry on kafka topic + clean dead code #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatte
changed the title
|
CDS Report terraform-provider-ovh-check#1755.0 ✔
|
|
CDS Report terraform-provider-ovh-check#1756.0 ✔
|
1 similar comment
|
CDS Report terraform-provider-ovh-check#1756.0 ✔
|
|
CDS Report terraform-provider-ovh-testacc#1756.0 ■ |
1 similar comment
|
CDS Report terraform-provider-ovh-testacc#1756.0 ■ |
|
CDS Report terraform-provider-ovh-check#1755.0 ✔
|
|
CDS Report terraform-provider-ovh-testacc#1755.0 ■ |
1 similar comment
|
CDS Report terraform-provider-ovh-testacc#1755.0 ■ |
lpatte
force-pushed
the
fix-kafka-conflict
branch
from
e8e6fd9
to
cda687a
Compare
|
CDS Report terraform-provider-ovh-check#1757.0 ✔
|
|
CDS Report terraform-provider-ovh-check#1758.0 ✔
|
|
CDS Report terraform-provider-ovh-testacc#1757.0 ✘
|
|
CDS Report terraform-provider-ovh-testacc#1758.0 ✘
|
scraly
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoir Conflict error on Kafka Topic, I add a retry logic on this resource
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc TESTARGS="-run TestAccCloudProjectDatabaseKafkaTopic_basic"