Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resource_me_identity update #443

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

fehrnah
Copy link
Contributor

@fehrnah fehrnah commented Jul 12, 2023

Description

A typo in the resource_me_identity resource implementation prevented user update. This PR fixes the typo and other errors rising from the fix.

Fixes #441

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Identity tests: make testacc TESTARGS="-run TestAccMeIdentity.*"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@fehrnah fehrnah force-pushed the fix/nfournier/fix-user-update branch from b6b601a to 7378f93 Compare July 12, 2023 10:43
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 12, 2023

CDS Report terraform-provider-ovh-check#1847.0 ■
*

  • checks ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 12, 2023

CDS Report terraform-provider-ovh-check#1847.0 ■
*

  • checks ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 12, 2023

CDS Report terraform-provider-ovh-check#1846.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 12, 2023

CDS Report terraform-provider-ovh-testacc#1846.0 ✘
*

  • checks ✘

@scraly
Copy link
Collaborator

scraly commented Aug 18, 2023

user created:
Capture d’écran 2023-08-18 à 14 39 20

user modified:
Capture d’écran 2023-08-18 à 14 40 26

login modified so a new user created/replaced instead:
Capture d’écran 2023-08-18 à 14 40 40

user deleted:
Capture d’écran 2023-08-18 à 14 41 02

Everything id OK for me

Thanks :)

@scraly scraly added the 0.33.0 label Aug 18, 2023
@scraly scraly merged commit fbe2721 into master Aug 18, 2023
@fehrnah fehrnah deleted the fix/nfournier/fix-user-update branch October 30, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ovh_me_identity_user not updating fields
3 participants