Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Database kafka schema registry #449

Merged

Conversation

BellionBastien
Copy link
Member

@BellionBastien BellionBastien commented Jul 31, 2023

Description

Adding resource and datasource for newly implemented schema registry ACL on kafka databases.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: make testacc TESTARGS="-run TestAccCloudProjectDatabaseKafkaSchemaregistryacl_basic"
  • Test B: make testacc TESTARGS="-run TestAccCloudProjectDatabaseKafkaSchemaregistryaclsDataSource_basic"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new feature is working, thanks! :-)

Just some remarks, typos and few changes requested.

ovh/data_cloud_project_database_kafka_schemaregistryacl.go Outdated Show resolved Hide resolved
ovh/data_cloud_project_database_kafka_schemaregistryacl.go Outdated Show resolved Hide resolved
ovh/data_cloud_project_database_kafka_schemaregistryacl.go Outdated Show resolved Hide resolved
ovh/data_cloud_project_database_kafka_schemaregistryacl.go Outdated Show resolved Hide resolved
ovh/data_cloud_project_database_kafka_schemaregistryacl.go Outdated Show resolved Hide resolved
BellionBastien and others added 11 commits August 18, 2023 11:58
@scraly scraly added the 0.33.0 label Aug 18, 2023
@scraly
Copy link
Collaborator

scraly commented Aug 18, 2023

Thanks, it's OK for me :)
create, update, destroy and the documentation are working.

@scraly scraly merged commit 35a7819 into ovh:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants