Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gateway's external information and interfaces #638

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

an0rak-dev
Copy link
Contributor

Description

  • expose gateway's external information
  • expose gateway's interfaces
  • fix a mapping issue in the REST response of a gateway's external information

This is done to implement this todo.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (improve existing resource(s) or datasource(s))
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Run locally using my own OVH public cloud account.

Test Configuration:

  • Terraform version: terraform version: Terraform v1.8.2
  • Existing HCL configuration you used:
resource "ovh_cloud_project_network_private" "priv_net" {
        service_name = var.ovh_project_number
        name = "private_network"
        regions = ["GRA11", "RBX-A"]
}

resource "ovh_cloud_project_network_private_subnet" "priv_subnet" {
        service_name = var.ovh_project_number
        network_id = ovh_cloud_project_network_private.priv_net.id
        dhcp = true
        region = "GRA11"
        start = "12.0.0.2"
        end = "12.0.0.254"
        network = "12.0.0.0/24"
        no_gateway = false
}

resource "ovh_cloud_project_gateway" "subnet_gateway" {
        service_name = var.ovh_project_number
        name = "gateway-GRA11"
        model = "m"
        region = "GRA11"
        network_id = ovh_cloud_project_network_private.priv_net.regions_attributes[0].openstackid
        subnet_id = ovh_cloud_project_network_private_subnet.priv_subnet.id
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

 * expose gateway's external information
 * expose gateway's interfaces
 * fix a mapping issue in the REST response of a gateway's external information
@an0rak-dev an0rak-dev marked this pull request as ready for review April 26, 2024 16:21
Copy link
Contributor

@amstuta amstuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution :)

@amstuta amstuta merged commit 3c70642 into ovh:master Apr 26, 2024
@an0rak-dev an0rak-dev deleted the expose_gateway_external_infos branch April 27, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants