Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate test runs from travis to github actions #10

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Conversation

falkenhawk
Copy link
Member

also includes php 8.0 and php 8.1, with allowance to fail

@falkenhawk falkenhawk self-assigned this Jul 13, 2022
Copy link

@partikus partikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 one more thing I would change

.github/workflows/tests.yml Show resolved Hide resolved
@falkenhawk
Copy link
Member Author

@marcing @partikus I have no idea why it fails on php 5.x. On travis it worked fine https://app.travis-ci.com/github/ovos/doctrine1/jobs/513037759

I cannot spend more time on this, I am leaving this for you

@partikus
Copy link

partikus commented Aug 9, 2022

😉

doctrine1 – 1674TestCase php 2022-08-09 06-20-02

I believe for PHP 5.3 we should use:

if (PHP_VERSION_ID >= 50300) {
            $this->assertEqual($xml, '<?xml version="1.0" encoding="utf-8"?>
<data><User id="4" type="0" email_id="1"><name>zYne</name><loginname/><password/><created/><updated/><Phonenumber><Phonenumber id="2" entity_id="4"><phonenumber>123 123</phonenumber><Entity/></Phonenumber></Phonenumber></User></data>
');
        } else {
            $this->assertEqual($xml, '<?xml version="1.0" encoding="utf-8"?>
<data><User id="4" type="0" email_id="1"><name>zYne</name><loginname></loginname><password></password><created></created><updated></updated><Phonenumber><Phonenumber id="2" entity_id="4"><phonenumber>123 123</phonenumber><Entity></Entity></Phonenumber></Phonenumber></User></data>
');
        }

but then, the bugfix does not make sense 😮

(on travis they worked fine https://app.travis-ci.com/github/ovos/doctrine1/jobs/513037759)

it does not help to explicitly enable apc for setup-php

apc/apcu are loaded and enabled by default for 5.x anyway
https://github.com/shivammathur/setup-php/wiki/Php-extensions-loaded-on-ubuntu-20.04

test of tests.yml

test of tests.yml

test of tests.yml

test of tests.yml

test of tests.yml
revert workaround for php 5.3 on travis - it was needed probably because some ancient version of libxml was installed there - no longer applicable for gha
@falkenhawk falkenhawk merged commit 5832011 into master Oct 4, 2022
@falkenhawk falkenhawk deleted the migrate-to-gha branch October 15, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants